Sign upLogin

nelsonic/hits

View on GitHub
Star

Showing 3 of 5 total issues

Function file_save_hit has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function file_save_hit (hit, callback) {
  var h = hit.split('|'); // See README.md#How secton for sample data
  var url = h[1];
  var LOG_FILE = path.join(LOG_DIR, 
      url.split('/').join('_').replace(':', '') + '.log');
Severity: Minor
Found in lib/db_filesystem.js - About 1 hr to fix

    Function handler has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function handler (req, res) {
  var url = req.url;
  var hit = extract(req);
  console.log(hit);
  if (url.match(/svg/)) {      // only return a badge if SVG requested
    Severity: Minor
    Found in server.js - About 1 hr to fix

      Function extract has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      module.exports = function extract (request) {
  var h = request.headers || {};          // shortcut to headers reduces typing
  var lang;                               // the browser language

  // get the user's IP addres from headers or connection object:
      Severity: Minor
      Found in lib/extract_request_data.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language