Sign upLogin

nemesiscodex/openfonacide

View on GitHub
Star
static/js/dncp/util/ecEffect.js

Summary

Maintainability
D
2 days
Test Coverage

Function line has 151 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function line(zr, effectList, shape, zlevel, isLarge) {
        var effect = shape.effect;
        var shapeStyle = shape.style;
        var color = effect.color || shapeStyle.strokeColor || shapeStyle.color;
        var shadowColor = effect.shadowColor || shapeStyle.strokeColor || color;
Severity: Major
Found in static/js/dncp/util/ecEffect.js - About 6 hrs to fix

    File ecEffect.js has 393 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * echarts图表特效基类
 *
 * @desc echarts基于Canvas，纯Javascript图表库，提供直观，生动，可交互，可个性化定制的数据统计图表。
 * @author Kener (@Kener-林峰, kener.linfeng@gmail.com)
    Severity: Minor
    Found in static/js/dncp/util/ecEffect.js - About 5 hrs to fix

      Function point has 112 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function point(zr, effectList, shape, zlevel) {
        var effect = shape.effect;
        var color = effect.color || shape.style.strokeColor || shape.style.color;
        var shadowColor = effect.shadowColor || color;
        var size = effect.scaleSize;
      Severity: Major
      Found in static/js/dncp/util/ecEffect.js - About 4 hrs to fix

        Function largeLine has 54 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function largeLine(zr, effectList, shape, zlevel) {
        var effectShape = new ShapeBundle({
            style: {
                shapeList: []
            },
        Severity: Major
        Found in static/js/dncp/util/ecEffect.js - About 2 hrs to fix

          Function largePoint has 50 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function largePoint(zr, effectList, shape, zlevel) {
        var effect = shape.effect;
        var color = effect.color || shape.style.strokeColor || shape.style.color;
        var size = effect.scaleSize;
        var shadowColor = effect.shadowColor || color;
          Severity: Minor
          Found in static/js/dncp/util/ecEffect.js - About 2 hrs to fix

            Function line has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                function line(zr, effectList, shape, zlevel, isLarge) {
            Severity: Minor
            Found in static/js/dncp/util/ecEffect.js - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          if (shape.style.iconType == 'pin') {
                effectShape.style.y += effectShape.style.height / 2 * 1.5;
            }
              Severity: Minor
              Found in static/js/dncp/util/ecEffect.js and 1 other location - About 45 mins to fix
              static/js/dncp/util/ecEffect.js on lines 93..95

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 50.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (shape.style.iconType == 'pin') {
            effectShape.style.y -= shape.style.height / 2 * 1.5;
        }
              Severity: Minor
              Found in static/js/dncp/util/ecEffect.js and 1 other location - About 45 mins to fix
              static/js/dncp/util/ecEffect.js on lines 53..55

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 50.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status