Sign upLogin

netceteragroup/valdr

View on GitHub
Star
src/core/validators/maxLengthValidator.spec.js

Summary

Maintainability
B
4 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it('should be invalid if value is number', function () {
    // given
    constraint.number = 2;

    // when
Severity: Major
Found in src/core/validators/maxLengthValidator.spec.js and 1 other location - About 1 hr to fix
src/core/validators/minLengthValidator.spec.js on lines 51..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  it('should return true if value is valid', function () {
    // given
    var value = 'a';

    // when
Severity: Major
Found in src/core/validators/maxLengthValidator.spec.js and 5 other locations - About 1 hr to fix
src/core/validators/maxLengthValidator.spec.js on lines 29..38
src/core/validators/minLengthValidator.spec.js on lines 18..27
src/core/validators/minLengthValidator.spec.js on lines 29..38
src/core/validators/sizeValidator.spec.js on lines 19..28
src/core/validators/sizeValidator.spec.js on lines 30..39

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  it('should return false if string exceeds maxLength', function () {
    // given
    var value = 'super long string that exceeds maxLength';

    // when
Severity: Major
Found in src/core/validators/maxLengthValidator.spec.js and 5 other locations - About 1 hr to fix
src/core/validators/maxLengthValidator.spec.js on lines 18..27
src/core/validators/minLengthValidator.spec.js on lines 18..27
src/core/validators/minLengthValidator.spec.js on lines 29..38
src/core/validators/sizeValidator.spec.js on lines 19..28
src/core/validators/sizeValidator.spec.js on lines 30..39

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status