netinvent/windows_tools

View on GitHub

Showing 44 of 46 total issues

Avoid too many return statements within this function.
Open

        return True
Severity: Major
Found in windows_tools/server/__init__.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return None
    Severity: Major
    Found in windows_tools/office/__init__.py - About 30 mins to fix

      Function get_version has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def get_version(self):
              """
              Get major / minor version as tuple
      
              """
      Severity: Minor
      Found in windows_tools/powershell/__init__.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function get_bitlocker_protection_key has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      def get_bitlocker_protection_key(drive: str) -> Union[str, None]:
          """
          Returns a string containing the protection key of a bitlocked drive
          """
          if not check_bitlocker_management_tools():
      Severity: Minor
      Found in windows_tools/bitlocker/__init__.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language