Sign upLogin

newscoop/JS-Scoopwriter

View on GitHub
Star
app/scripts/controllers/comments.js

Summary

Maintainability
F
4 days
Test Coverage

File comments.js has 292 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

/**
* AngularJS controller for managing article comments (as a group,
* not individual comments).
Severity: Minor
Found in app/scripts/controllers/comments.js - About 3 hrs to fix

    Function confirmHideComments has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            $scope.confirmHideComments = function (commentId) {
            var commentIdGiven = (typeof commentId !== 'undefined'),
                modal,
                title,
                text;
    Severity: Minor
    Found in app/scripts/controllers/comments.js - About 1 hr to fix

      Function confirmDeleteComments has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              $scope.confirmDeleteComments = function (commentId) {
            var commentIdGiven = (typeof commentId !== 'undefined'),
                modal,
                title,
                text;
      Severity: Minor
      Found in app/scripts/controllers/comments.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                $scope.confirmDeleteComments = function (commentId) {
            var commentIdGiven = (typeof commentId !== 'undefined'),
                modal,
                title,
                text;
        Severity: Major
        Found in app/scripts/controllers/comments.js and 1 other location - About 1 day to fix
        app/scripts/controllers/comments.js on lines 313..348

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 208.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                $scope.confirmHideComments = function (commentId) {
            var commentIdGiven = (typeof commentId !== 'undefined'),
                modal,
                title,
                text;
        Severity: Major
        Found in app/scripts/controllers/comments.js and 1 other location - About 1 day to fix
        app/scripts/controllers/comments.js on lines 360..395

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 208.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                $scope.add = function (par) {
            $scope.isSending = true;
            comments.add(par).then(function () {
                $scope.adding = false;
                // collapse the form
        Severity: Major
        Found in app/scripts/controllers/comments.js and 1 other location - About 6 hrs to fix
        app/scripts/controllers/editorial-comments.js on lines 83..107

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 169.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                $scope.saveComment = function (comment) {
            comment.save().then(function () {
                toaster.add({
                    type: 'sf-info',
                    message: TranslationService.trans(
        Severity: Major
        Found in app/scripts/controllers/comments.js and 3 other locations - About 3 hrs to fix
        app/scripts/controllers/comments.js on lines 209..225
        app/scripts/controllers/editorial-comments.js on lines 115..131
        app/scripts/controllers/editorial-comments.js on lines 139..155

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 110.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                $scope.sendReply = function (comment) {
            comment.sendReply().then(function () {
                toaster.add({
                    type: 'sf-info',
                    message: TranslationService.trans(
        Severity: Major
        Found in app/scripts/controllers/comments.js and 3 other locations - About 3 hrs to fix
        app/scripts/controllers/comments.js on lines 185..201
        app/scripts/controllers/editorial-comments.js on lines 115..131
        app/scripts/controllers/editorial-comments.js on lines 139..155

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 110.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status