newscoop/JS-Scoopwriter

View on GitHub
app/scripts/directives/drag-sort.js

Summary

Maintainability
C
1 day
Test Coverage

Function linkFunction has 121 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function linkFunction(scope, element, attrs) {
        var newIdx = -1,  // dragged element's (potential) new position
            $emptySlot = null,  // DOM marker for the new position
            $rootElement,  // root DOM element the directive is applied to
            draggedElementIdx = -1;  // index of the element being dragged
Severity: Major
Found in app/scripts/directives/drag-sort.js - About 4 hrs to fix

    Function setEventHandlers has 72 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            function setEventHandlers($element) {
                $element.attr('draggable', true);
    
                $element.on('dragstart', function (e) {
                    var dragData;
    Severity: Major
    Found in app/scripts/directives/drag-sort.js - About 2 hrs to fix

      Function setContainerEventHandlers has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              function setContainerEventHandlers($container, scope) {
                  $container.on('dragover', function (e) {
                      e.originalEvent.preventDefault();  // allow drop
                      e.originalEvent.dataTransfer.dropEffect = 'move';
                  });
      Severity: Minor
      Found in app/scripts/directives/drag-sort.js - About 1 hr to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                    $container.on('dragover', function (e) {
                        e.originalEvent.preventDefault();  // allow drop
                        e.originalEvent.dataTransfer.dropEffect = 'move';
                    });
        Severity: Major
        Found in app/scripts/directives/drag-sort.js and 2 other locations - About 1 hr to fix
        app/scripts/directives/drag-sort.js on lines 63..66
        app/scripts/directives/drag-sort.js on lines 148..151

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                    $element.on('dragenter', function (e) {
                        e.originalEvent.preventDefault();  // allow drop (for IE)
                        e.originalEvent.dataTransfer.dropEffect = 'move';
                    });
        Severity: Major
        Found in app/scripts/directives/drag-sort.js and 2 other locations - About 1 hr to fix
        app/scripts/directives/drag-sort.js on lines 143..146
        app/scripts/directives/drag-sort.js on lines 148..151

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                    $container.on('dragenter', function (e) {
                        e.originalEvent.preventDefault();  // allow drop (IE)
                        e.originalEvent.dataTransfer.dropEffect = 'move';
                    });
        Severity: Major
        Found in app/scripts/directives/drag-sort.js and 2 other locations - About 1 hr to fix
        app/scripts/directives/drag-sort.js on lines 63..66
        app/scripts/directives/drag-sort.js on lines 143..146

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status