Sign upLogin

newscoop/JS-Scoopwriter

View on GitHub
Star
app/scripts/services/Author.js

Summary

Maintainability
D
1 day
Test Coverage

File Author.js has 272 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

/**
* A factory which creates article author model.
*
Severity: Minor
Found in app/scripts/services/Author.js - About 2 hrs to fix

    Function liveSearchQuery has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            Author.liveSearchQuery = function (options, isCallback) {
            var isPaginationCall = (options.page > 1),
                now = dateFactory.makeInstance(),
                url;
    Severity: Minor
    Found in app/scripts/services/Author.js - About 1 hr to fix

      Function addToArticle has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              Author.prototype.addToArticle = function (number, language, roleId) {
            var author = this,
                deferred = $q.defer(),
                linkHeader,
                url;
      Severity: Minor
      Found in app/scripts/services/Author.js - About 1 hr to fix

        Function removeFromArticle has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                Author.prototype.removeFromArticle = function (
            number, language, roleId
        ) {
            var author = this,
                deferred = $q.defer(),
        Severity: Minor
        Found in app/scripts/services/Author.js - About 1 hr to fix

          Function updateRole has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  Author.prototype.updateRole = function (params) {
            var headersParam,
                linkHeader,
                promise,
                url;
          Severity: Minor
          Found in app/scripts/services/Author.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        if (!isCallback) {
                // regular select2's onType event, input changed

                if (!isPaginationCall) {
                    lastTermChange = now;
            Severity: Major
            Found in app/scripts/services/Author.js and 1 other location - About 3 hrs to fix
            app/scripts/services/Topic.js on lines 144..165

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 98.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        linkHeader = [
                '<',
                Routing.generate(
                    'newscoop_gimme_authors_getauthorbyid',
                    {id: author.id},
            Severity: Major
            Found in app/scripts/services/Author.js and 1 other location - About 1 hr to fix
            app/scripts/services/Author.js on lines 310..325

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        linkHeader = [
                '<',
                Routing.generate(
                    'newscoop_gimme_authors_getauthorbyid',
                    {id: author.id},
            Severity: Major
            Found in app/scripts/services/Author.js and 1 other location - About 1 hr to fix
            app/scripts/services/Author.js on lines 250..265

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            options.callback({
                    results: authorList,
                    more: !pageTracker.isLastPage(response.pagination),
                    context: response.pagination
                });
            Severity: Minor
            Found in app/scripts/services/Author.js and 1 other location - About 30 mins to fix
            app/scripts/services/Topic.js on lines 191..195

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status