Sign upLogin

newscoop/JS-Scoopwriter

View on GitHub
Star
app/scripts/services/NcImage.js

Summary

Maintainability
D
2 days
Test Coverage

Function upload has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        NcImage.upload = function (image, onProgress) {
            var deferred = $q.defer(),
                fd = formDataFactory.makeInstance(),
                parts,
                rejectMsg = 'No x-location header in API response.';
Severity: Minor
Found in app/scripts/services/NcImage.js - About 1 hr to fix

    Function query has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            NcImage.query = function (page, itemsPerPage, searchFilter) {
            var deferredGet = $q.defer(),
                requestOptions,
                results = [],
                url;
    Severity: Minor
    Found in app/scripts/services/NcImage.js - About 1 hr to fix

      Function addAllToArticle has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              NcImage.addAllToArticle = function (articleId, articleLang, images) {
            var deferred = $q.defer(),
                linkHeader = [];

            images.forEach(function (item) {
      Severity: Minor
      Found in app/scripts/services/NcImage.js - About 1 hr to fix

        Function getAllByArticle has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                NcImage.getAllByArticle = function (articleId, language) {
            var deferredGet = $q.defer(),
                requestOptions,
                images = [];
        Severity: Minor
        Found in app/scripts/services/NcImage.js - About 1 hr to fix

          Function updateDescription has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  NcImage.prototype.updateDescription = function (newDesc) {
            var deferredPatch = $q.defer(),
                params,
                self = this,
                url;
          Severity: Minor
          Found in app/scripts/services/NcImage.js - About 1 hr to fix

            Function removeFromArticle has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    NcImage.prototype.removeFromArticle = function(articleId, language) {
            var self = this,
                deferred = $q.defer(),
                linkHeader;
            Severity: Minor
            Found in app/scripts/services/NcImage.js - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      NcImage.prototype.removeFromArticle = function(articleId, language) {
            var self = this,
                deferred = $q.defer(),
                linkHeader;
              Severity: Major
              Found in app/scripts/services/NcImage.js and 1 other location - About 7 hrs to fix
              app/scripts/services/Snippet.js on lines 220..250

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 186.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                              if (response.items) {
                    response.items.forEach(function (item) {
                        item = new NcImage(item);
                        results.push(item);
                    });
              Severity: Minor
              Found in app/scripts/services/NcImage.js and 1 other location - About 55 mins to fix
              app/scripts/services/NcImage.js on lines 174..179

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 54.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                              if (response.items) {
                    response.items.forEach(function (item) {
                        item = new NcImage(item);
                        images.push(item);
                    });
              Severity: Minor
              Found in app/scripts/services/NcImage.js and 1 other location - About 55 mins to fix
              app/scripts/services/NcImage.js on lines 122..127

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 54.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status