Sign upLogin

newscoop/JS-Scoopwriter

View on GitHub
Star
app/scripts/services/editorial-comments.js

Summary

Maintainability
D
2 days
Test Coverage

Function decorate has 113 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        function decorate(comment) {
            /**
            * @class comment
            */
Severity: Major
Found in app/scripts/services/editorial-comments.js - About 4 hrs to fix

    File editorial-comments.js has 314 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    'use strict';

/**
* AngularJS Service for managing article comments.
*
    Severity: Minor
    Found in app/scripts/services/editorial-comments.js - About 3 hrs to fix

      Function getAllByPage has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              self.getAllByPage = function (page) {
            var deferredGet = $q.defer(),
                url;

            var totalPerPage = itemsPerPage * latestPage;
      Severity: Minor
      Found in app/scripts/services/editorial-comments.js - About 1 hr to fix

        Function add has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                self.add = function (parameters) {
            var deferred = $q.defer(),
                url;

            url = Routing.generate(
        Severity: Minor
        Found in app/scripts/services/editorial-comments.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          if (self.canLoadMore) {
                    // prepare the next batch
                    self.getAllByPage(self.tracker.next()).then(
                        function (response) {
                            self.loaded = self.loaded.concat(response.items);
          Severity: Major
          Found in app/scripts/services/editorial-comments.js and 1 other location - About 2 hrs to fix
          app/scripts/services/comments.js on lines 170..175

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 76.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      comment.toggle = function () {
                if ('expanded' === this.showStatus) {
                    this.collapse();
                } else {
                    this.expand();
          Severity: Major
          Found in app/scripts/services/editorial-comments.js and 1 other location - About 1 hr to fix
          app/scripts/services/comments.js on lines 463..469

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      url = Routing.generate(
                'newscoop_gimme_articles_get_editorial_comments',
                {
                    language: article.language,
                    number: article.articleId,
          Severity: Minor
          Found in app/scripts/services/editorial-comments.js and 1 other location - About 50 mins to fix
          app/scripts/services/comments.js on lines 225..235

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                          url = Routing.generate(
                    'newscoop_gimme_articles_edit_editorial_comment',
                    {
                        number: article.articleId,
                        language: article.languageData.id,
          Severity: Minor
          Found in app/scripts/services/editorial-comments.js and 1 other location - About 40 mins to fix
          app/scripts/services/editorial-comments.js on lines 469..477

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                          url = Routing.generate(
                    'newscoop_gimme_articles_edit_editorial_comment',
                    {
                        number: article.articleId,
                        language: article.languageData.id,
          Severity: Minor
          Found in app/scripts/services/editorial-comments.js and 1 other location - About 40 mins to fix
          app/scripts/services/editorial-comments.js on lines 418..426

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status