Sign upLogin

next-l/enju_leaf

View on GitHub
Star

Showing 364 of 709 total issues

Similar blocks of code found in 35 locations. Consider refactoring.
Open

  def destroy
    @medium_of_performance.destroy

    respond_to do |format|
      format.html { redirect_to medium_of_performances_url, notice: t('controller.successfully_deleted', model: t('activerecord.models.medium_of_performance')) }
Severity: Major
Found in app/controllers/medium_of_performances_controller.rb and 34 other locations - About 15 mins to fix
app/controllers/accepts_controller.rb on lines 105..110
app/controllers/agent_import_files_controller.rb on lines 71..76
app/controllers/agent_import_results_controller.rb on lines 33..38
app/controllers/agent_relationship_types_controller.rb on lines 69..74
app/controllers/agent_types_controller.rb on lines 69..74
app/controllers/agents_controller.rb on lines 181..186
app/controllers/bookstores_controller.rb on lines 69..74
app/controllers/budget_types_controller.rb on lines 69..74
app/controllers/carrier_types_controller.rb on lines 76..81
app/controllers/classification_types_controller.rb on lines 69..74
app/controllers/content_types_controller.rb on lines 69..74
app/controllers/countries_controller.rb on lines 69..74
app/controllers/create_types_controller.rb on lines 69..74
app/controllers/event_categories_controller.rb on lines 69..74
app/controllers/event_import_results_controller.rb on lines 31..36
app/controllers/form_of_works_controller.rb on lines 69..74
app/controllers/frequencies_controller.rb on lines 69..74
app/controllers/identifier_types_controller.rb on lines 69..74
app/controllers/import_requests_controller.rb on lines 85..90
app/controllers/languages_controller.rb on lines 69..74
app/controllers/licenses_controller.rb on lines 69..74
app/controllers/manifestation_relationship_types_controller.rb on lines 69..74
app/controllers/nii_types_controller.rb on lines 69..74
app/controllers/produce_types_controller.rb on lines 69..74
app/controllers/profiles_controller.rb on lines 146..151
app/controllers/realize_types_controller.rb on lines 69..74
app/controllers/resource_import_files_controller.rb on lines 77..82
app/controllers/resource_import_results_controller.rb on lines 35..40
app/controllers/search_engines_controller.rb on lines 69..74
app/controllers/subject_heading_types_controller.rb on lines 69..74
app/controllers/subject_types_controller.rb on lines 69..74
app/controllers/subjects_controller.rb on lines 115..120
app/controllers/user_import_results_controller.rb on lines 31..36
app/controllers/withdraws_controller.rb on lines 106..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 35 locations. Consider refactoring.
Open

  def destroy
    @subject_type.destroy

    respond_to do |format|
      format.html { redirect_to subject_types_url, notice: t('controller.successfully_deleted', model: t('activerecord.models.subject_type')) }
Severity: Major
Found in app/controllers/subject_types_controller.rb and 34 other locations - About 15 mins to fix
app/controllers/accepts_controller.rb on lines 105..110
app/controllers/agent_import_files_controller.rb on lines 71..76
app/controllers/agent_import_results_controller.rb on lines 33..38
app/controllers/agent_relationship_types_controller.rb on lines 69..74
app/controllers/agent_types_controller.rb on lines 69..74
app/controllers/agents_controller.rb on lines 181..186
app/controllers/bookstores_controller.rb on lines 69..74
app/controllers/budget_types_controller.rb on lines 69..74
app/controllers/carrier_types_controller.rb on lines 76..81
app/controllers/classification_types_controller.rb on lines 69..74
app/controllers/content_types_controller.rb on lines 69..74
app/controllers/countries_controller.rb on lines 69..74
app/controllers/create_types_controller.rb on lines 69..74
app/controllers/event_categories_controller.rb on lines 69..74
app/controllers/event_import_results_controller.rb on lines 31..36
app/controllers/form_of_works_controller.rb on lines 69..74
app/controllers/frequencies_controller.rb on lines 69..74
app/controllers/identifier_types_controller.rb on lines 69..74
app/controllers/import_requests_controller.rb on lines 85..90
app/controllers/languages_controller.rb on lines 69..74
app/controllers/licenses_controller.rb on lines 69..74
app/controllers/manifestation_relationship_types_controller.rb on lines 69..74
app/controllers/medium_of_performances_controller.rb on lines 69..74
app/controllers/nii_types_controller.rb on lines 69..74
app/controllers/produce_types_controller.rb on lines 69..74
app/controllers/profiles_controller.rb on lines 146..151
app/controllers/realize_types_controller.rb on lines 69..74
app/controllers/resource_import_files_controller.rb on lines 77..82
app/controllers/resource_import_results_controller.rb on lines 35..40
app/controllers/search_engines_controller.rb on lines 69..74
app/controllers/subject_heading_types_controller.rb on lines 69..74
app/controllers/subjects_controller.rb on lines 115..120
app/controllers/user_import_results_controller.rb on lines 31..36
app/controllers/withdraws_controller.rb on lines 106..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

  Manifestation.where.not(attachment_file_name: nil).find_each do |file|
    file.attachment.attach(
      io: File.open(Paperclip::Attachment.new(
        :attachment,
        file,
Severity: Major
Found in lib/tasks/attachment.rb and 10 other locations - About 15 mins to fix
lib/tasks/attachment.rb on lines 6..14
lib/tasks/attachment.rb on lines 17..25
lib/tasks/attachment.rb on lines 28..36
lib/tasks/attachment.rb on lines 39..47
lib/tasks/attachment.rb on lines 50..58
lib/tasks/attachment.rb on lines 61..69
lib/tasks/attachment.rb on lines 95..103
lib/tasks/attachment.rb on lines 106..114
lib/tasks/attachment.rb on lines 117..125
lib/tasks/attachment.rb on lines 128..136

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 35 locations. Consider refactoring.
Open

  def destroy
    @nii_type.destroy

    respond_to do |format|
      format.html { redirect_to nii_types_url, notice: t('controller.successfully_deleted', model: t('activerecord.models.nii_type')) }
Severity: Major
Found in app/controllers/nii_types_controller.rb and 34 other locations - About 15 mins to fix
app/controllers/accepts_controller.rb on lines 105..110
app/controllers/agent_import_files_controller.rb on lines 71..76
app/controllers/agent_import_results_controller.rb on lines 33..38
app/controllers/agent_relationship_types_controller.rb on lines 69..74
app/controllers/agent_types_controller.rb on lines 69..74
app/controllers/agents_controller.rb on lines 181..186
app/controllers/bookstores_controller.rb on lines 69..74
app/controllers/budget_types_controller.rb on lines 69..74
app/controllers/carrier_types_controller.rb on lines 76..81
app/controllers/classification_types_controller.rb on lines 69..74
app/controllers/content_types_controller.rb on lines 69..74
app/controllers/countries_controller.rb on lines 69..74
app/controllers/create_types_controller.rb on lines 69..74
app/controllers/event_categories_controller.rb on lines 69..74
app/controllers/event_import_results_controller.rb on lines 31..36
app/controllers/form_of_works_controller.rb on lines 69..74
app/controllers/frequencies_controller.rb on lines 69..74
app/controllers/identifier_types_controller.rb on lines 69..74
app/controllers/import_requests_controller.rb on lines 85..90
app/controllers/languages_controller.rb on lines 69..74
app/controllers/licenses_controller.rb on lines 69..74
app/controllers/manifestation_relationship_types_controller.rb on lines 69..74
app/controllers/medium_of_performances_controller.rb on lines 69..74
app/controllers/produce_types_controller.rb on lines 69..74
app/controllers/profiles_controller.rb on lines 146..151
app/controllers/realize_types_controller.rb on lines 69..74
app/controllers/resource_import_files_controller.rb on lines 77..82
app/controllers/resource_import_results_controller.rb on lines 35..40
app/controllers/search_engines_controller.rb on lines 69..74
app/controllers/subject_heading_types_controller.rb on lines 69..74
app/controllers/subject_types_controller.rb on lines 69..74
app/controllers/subjects_controller.rb on lines 115..120
app/controllers/user_import_results_controller.rb on lines 31..36
app/controllers/withdraws_controller.rb on lines 106..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 35 locations. Consider refactoring.
Open

  def destroy
    @realize_type.destroy

    respond_to do |format|
      format.html { redirect_to realize_types_url, notice: t('controller.successfully_deleted', model: t('activerecord.models.realize_type')) }
Severity: Major
Found in app/controllers/realize_types_controller.rb and 34 other locations - About 15 mins to fix
app/controllers/accepts_controller.rb on lines 105..110
app/controllers/agent_import_files_controller.rb on lines 71..76
app/controllers/agent_import_results_controller.rb on lines 33..38
app/controllers/agent_relationship_types_controller.rb on lines 69..74
app/controllers/agent_types_controller.rb on lines 69..74
app/controllers/agents_controller.rb on lines 181..186
app/controllers/bookstores_controller.rb on lines 69..74
app/controllers/budget_types_controller.rb on lines 69..74
app/controllers/carrier_types_controller.rb on lines 76..81
app/controllers/classification_types_controller.rb on lines 69..74
app/controllers/content_types_controller.rb on lines 69..74
app/controllers/countries_controller.rb on lines 69..74
app/controllers/create_types_controller.rb on lines 69..74
app/controllers/event_categories_controller.rb on lines 69..74
app/controllers/event_import_results_controller.rb on lines 31..36
app/controllers/form_of_works_controller.rb on lines 69..74
app/controllers/frequencies_controller.rb on lines 69..74
app/controllers/identifier_types_controller.rb on lines 69..74
app/controllers/import_requests_controller.rb on lines 85..90
app/controllers/languages_controller.rb on lines 69..74
app/controllers/licenses_controller.rb on lines 69..74
app/controllers/manifestation_relationship_types_controller.rb on lines 69..74
app/controllers/medium_of_performances_controller.rb on lines 69..74
app/controllers/nii_types_controller.rb on lines 69..74
app/controllers/produce_types_controller.rb on lines 69..74
app/controllers/profiles_controller.rb on lines 146..151
app/controllers/resource_import_files_controller.rb on lines 77..82
app/controllers/resource_import_results_controller.rb on lines 35..40
app/controllers/search_engines_controller.rb on lines 69..74
app/controllers/subject_heading_types_controller.rb on lines 69..74
app/controllers/subject_types_controller.rb on lines 69..74
app/controllers/subjects_controller.rb on lines 115..120
app/controllers/user_import_results_controller.rb on lines 31..36
app/controllers/withdraws_controller.rb on lines 106..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 35 locations. Consider refactoring.
Open

  def destroy
    @bookstore.destroy

    respond_to do |format|
      format.html { redirect_to bookstores_url, notice: t('controller.successfully_deleted', model: t('activerecord.models.bookstore')) }
Severity: Major
Found in app/controllers/bookstores_controller.rb and 34 other locations - About 15 mins to fix
app/controllers/accepts_controller.rb on lines 105..110
app/controllers/agent_import_files_controller.rb on lines 71..76
app/controllers/agent_import_results_controller.rb on lines 33..38
app/controllers/agent_relationship_types_controller.rb on lines 69..74
app/controllers/agent_types_controller.rb on lines 69..74
app/controllers/agents_controller.rb on lines 181..186
app/controllers/budget_types_controller.rb on lines 69..74
app/controllers/carrier_types_controller.rb on lines 76..81
app/controllers/classification_types_controller.rb on lines 69..74
app/controllers/content_types_controller.rb on lines 69..74
app/controllers/countries_controller.rb on lines 69..74
app/controllers/create_types_controller.rb on lines 69..74
app/controllers/event_categories_controller.rb on lines 69..74
app/controllers/event_import_results_controller.rb on lines 31..36
app/controllers/form_of_works_controller.rb on lines 69..74
app/controllers/frequencies_controller.rb on lines 69..74
app/controllers/identifier_types_controller.rb on lines 69..74
app/controllers/import_requests_controller.rb on lines 85..90
app/controllers/languages_controller.rb on lines 69..74
app/controllers/licenses_controller.rb on lines 69..74
app/controllers/manifestation_relationship_types_controller.rb on lines 69..74
app/controllers/medium_of_performances_controller.rb on lines 69..74
app/controllers/nii_types_controller.rb on lines 69..74
app/controllers/produce_types_controller.rb on lines 69..74
app/controllers/profiles_controller.rb on lines 146..151
app/controllers/realize_types_controller.rb on lines 69..74
app/controllers/resource_import_files_controller.rb on lines 77..82
app/controllers/resource_import_results_controller.rb on lines 35..40
app/controllers/search_engines_controller.rb on lines 69..74
app/controllers/subject_heading_types_controller.rb on lines 69..74
app/controllers/subject_types_controller.rb on lines 69..74
app/controllers/subjects_controller.rb on lines 115..120
app/controllers/user_import_results_controller.rb on lines 31..36
app/controllers/withdraws_controller.rb on lines 106..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 35 locations. Consider refactoring.
Open

  def destroy
    @agent.destroy

    respond_to do |format|
      format.html { redirect_to agents_url, notice: t('controller.successfully_deleted', model: t('activerecord.models.agent')) }
Severity: Major
Found in app/controllers/agents_controller.rb and 34 other locations - About 15 mins to fix
app/controllers/accepts_controller.rb on lines 105..110
app/controllers/agent_import_files_controller.rb on lines 71..76
app/controllers/agent_import_results_controller.rb on lines 33..38
app/controllers/agent_relationship_types_controller.rb on lines 69..74
app/controllers/agent_types_controller.rb on lines 69..74
app/controllers/bookstores_controller.rb on lines 69..74
app/controllers/budget_types_controller.rb on lines 69..74
app/controllers/carrier_types_controller.rb on lines 76..81
app/controllers/classification_types_controller.rb on lines 69..74
app/controllers/content_types_controller.rb on lines 69..74
app/controllers/countries_controller.rb on lines 69..74
app/controllers/create_types_controller.rb on lines 69..74
app/controllers/event_categories_controller.rb on lines 69..74
app/controllers/event_import_results_controller.rb on lines 31..36
app/controllers/form_of_works_controller.rb on lines 69..74
app/controllers/frequencies_controller.rb on lines 69..74
app/controllers/identifier_types_controller.rb on lines 69..74
app/controllers/import_requests_controller.rb on lines 85..90
app/controllers/languages_controller.rb on lines 69..74
app/controllers/licenses_controller.rb on lines 69..74
app/controllers/manifestation_relationship_types_controller.rb on lines 69..74
app/controllers/medium_of_performances_controller.rb on lines 69..74
app/controllers/nii_types_controller.rb on lines 69..74
app/controllers/produce_types_controller.rb on lines 69..74
app/controllers/profiles_controller.rb on lines 146..151
app/controllers/realize_types_controller.rb on lines 69..74
app/controllers/resource_import_files_controller.rb on lines 77..82
app/controllers/resource_import_results_controller.rb on lines 35..40
app/controllers/search_engines_controller.rb on lines 69..74
app/controllers/subject_heading_types_controller.rb on lines 69..74
app/controllers/subject_types_controller.rb on lines 69..74
app/controllers/subjects_controller.rb on lines 115..120
app/controllers/user_import_results_controller.rb on lines 31..36
app/controllers/withdraws_controller.rb on lines 106..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

  UserExportFile.where.not(user_export_file_name: nil).find_each do |file|
    file.attachment.attach(
      io: File.open(Paperclip::Attachment.new(
        :user_export,
        file,
Severity: Major
Found in lib/tasks/attachment.rb and 10 other locations - About 15 mins to fix
lib/tasks/attachment.rb on lines 6..14
lib/tasks/attachment.rb on lines 17..25
lib/tasks/attachment.rb on lines 28..36
lib/tasks/attachment.rb on lines 39..47
lib/tasks/attachment.rb on lines 50..58
lib/tasks/attachment.rb on lines 61..69
lib/tasks/attachment.rb on lines 72..80
lib/tasks/attachment.rb on lines 95..103
lib/tasks/attachment.rb on lines 106..114
lib/tasks/attachment.rb on lines 128..136

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

  UserImportFile.where.not(user_import_file_name: nil).find_each do |file|
    file.attachment.attach(
      io: File.open(Paperclip::Attachment.new(
        :user_import,
        file,
Severity: Major
Found in lib/tasks/attachment.rb and 10 other locations - About 15 mins to fix
lib/tasks/attachment.rb on lines 6..14
lib/tasks/attachment.rb on lines 17..25
lib/tasks/attachment.rb on lines 28..36
lib/tasks/attachment.rb on lines 39..47
lib/tasks/attachment.rb on lines 50..58
lib/tasks/attachment.rb on lines 61..69
lib/tasks/attachment.rb on lines 72..80
lib/tasks/attachment.rb on lines 95..103
lib/tasks/attachment.rb on lines 106..114
lib/tasks/attachment.rb on lines 117..125

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

  AgentImportFile.where.not(agent_import_file_name: nil).find_each do |file|
    file.attachment.attach(
      io: URI(Paperclip::Attachment.new(
        :agent_import,
        file,
Severity: Major
Found in lib/tasks/attachment.rb and 10 other locations - About 15 mins to fix
lib/tasks/attachment.rb on lines 152..160
lib/tasks/attachment.rb on lines 163..171
lib/tasks/attachment.rb on lines 174..182
lib/tasks/attachment.rb on lines 185..193
lib/tasks/attachment.rb on lines 196..204
lib/tasks/attachment.rb on lines 207..215
lib/tasks/attachment.rb on lines 236..244
lib/tasks/attachment.rb on lines 247..255
lib/tasks/attachment.rb on lines 258..266
lib/tasks/attachment.rb on lines 269..277

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 35 locations. Consider refactoring.
Open

  def destroy
    @agent_import_file.destroy

    respond_to do |format|
      format.html { redirect_to agent_import_files_url, notice: t('controller.successfully_deleted', model: t('activerecord.models.agent_import_file')) }
Severity: Major
Found in app/controllers/agent_import_files_controller.rb and 34 other locations - About 15 mins to fix
app/controllers/accepts_controller.rb on lines 105..110
app/controllers/agent_import_results_controller.rb on lines 33..38
app/controllers/agent_relationship_types_controller.rb on lines 69..74
app/controllers/agent_types_controller.rb on lines 69..74
app/controllers/agents_controller.rb on lines 181..186
app/controllers/bookstores_controller.rb on lines 69..74
app/controllers/budget_types_controller.rb on lines 69..74
app/controllers/carrier_types_controller.rb on lines 76..81
app/controllers/classification_types_controller.rb on lines 69..74
app/controllers/content_types_controller.rb on lines 69..74
app/controllers/countries_controller.rb on lines 69..74
app/controllers/create_types_controller.rb on lines 69..74
app/controllers/event_categories_controller.rb on lines 69..74
app/controllers/event_import_results_controller.rb on lines 31..36
app/controllers/form_of_works_controller.rb on lines 69..74
app/controllers/frequencies_controller.rb on lines 69..74
app/controllers/identifier_types_controller.rb on lines 69..74
app/controllers/import_requests_controller.rb on lines 85..90
app/controllers/languages_controller.rb on lines 69..74
app/controllers/licenses_controller.rb on lines 69..74
app/controllers/manifestation_relationship_types_controller.rb on lines 69..74
app/controllers/medium_of_performances_controller.rb on lines 69..74
app/controllers/nii_types_controller.rb on lines 69..74
app/controllers/produce_types_controller.rb on lines 69..74
app/controllers/profiles_controller.rb on lines 146..151
app/controllers/realize_types_controller.rb on lines 69..74
app/controllers/resource_import_files_controller.rb on lines 77..82
app/controllers/resource_import_results_controller.rb on lines 35..40
app/controllers/search_engines_controller.rb on lines 69..74
app/controllers/subject_heading_types_controller.rb on lines 69..74
app/controllers/subject_types_controller.rb on lines 69..74
app/controllers/subjects_controller.rb on lines 115..120
app/controllers/user_import_results_controller.rb on lines 31..36
app/controllers/withdraws_controller.rb on lines 106..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 35 locations. Consider refactoring.
Open

  def destroy
    @license.destroy

    respond_to do |format|
      format.html { redirect_to licenses_url, notice: t('controller.successfully_deleted', model: t('activerecord.models.license')) }
Severity: Major
Found in app/controllers/licenses_controller.rb and 34 other locations - About 15 mins to fix
app/controllers/accepts_controller.rb on lines 105..110
app/controllers/agent_import_files_controller.rb on lines 71..76
app/controllers/agent_import_results_controller.rb on lines 33..38
app/controllers/agent_relationship_types_controller.rb on lines 69..74
app/controllers/agent_types_controller.rb on lines 69..74
app/controllers/agents_controller.rb on lines 181..186
app/controllers/bookstores_controller.rb on lines 69..74
app/controllers/budget_types_controller.rb on lines 69..74
app/controllers/carrier_types_controller.rb on lines 76..81
app/controllers/classification_types_controller.rb on lines 69..74
app/controllers/content_types_controller.rb on lines 69..74
app/controllers/countries_controller.rb on lines 69..74
app/controllers/create_types_controller.rb on lines 69..74
app/controllers/event_categories_controller.rb on lines 69..74
app/controllers/event_import_results_controller.rb on lines 31..36
app/controllers/form_of_works_controller.rb on lines 69..74
app/controllers/frequencies_controller.rb on lines 69..74
app/controllers/identifier_types_controller.rb on lines 69..74
app/controllers/import_requests_controller.rb on lines 85..90
app/controllers/languages_controller.rb on lines 69..74
app/controllers/manifestation_relationship_types_controller.rb on lines 69..74
app/controllers/medium_of_performances_controller.rb on lines 69..74
app/controllers/nii_types_controller.rb on lines 69..74
app/controllers/produce_types_controller.rb on lines 69..74
app/controllers/profiles_controller.rb on lines 146..151
app/controllers/realize_types_controller.rb on lines 69..74
app/controllers/resource_import_files_controller.rb on lines 77..82
app/controllers/resource_import_results_controller.rb on lines 35..40
app/controllers/search_engines_controller.rb on lines 69..74
app/controllers/subject_heading_types_controller.rb on lines 69..74
app/controllers/subject_types_controller.rb on lines 69..74
app/controllers/subjects_controller.rb on lines 115..120
app/controllers/user_import_results_controller.rb on lines 31..36
app/controllers/withdraws_controller.rb on lines 106..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

  InventoryFile.where.not(inventory_file_name: nil).find_each do |file|
    file.attachment.attach(
      io: File.open(Paperclip::Attachment.new(
        :inventory,
        file,
Severity: Major
Found in lib/tasks/attachment.rb and 10 other locations - About 15 mins to fix
lib/tasks/attachment.rb on lines 6..14
lib/tasks/attachment.rb on lines 17..25
lib/tasks/attachment.rb on lines 28..36
lib/tasks/attachment.rb on lines 39..47
lib/tasks/attachment.rb on lines 61..69
lib/tasks/attachment.rb on lines 72..80
lib/tasks/attachment.rb on lines 95..103
lib/tasks/attachment.rb on lines 106..114
lib/tasks/attachment.rb on lines 117..125
lib/tasks/attachment.rb on lines 128..136

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

  InventoryFile.where.not(inventory_file_name: nil).find_each do |file|
    file.attachment.attach(
      io: URI(Paperclip::Attachment.new(
        :inventory,
        file,
Severity: Major
Found in lib/tasks/attachment.rb and 10 other locations - About 15 mins to fix
lib/tasks/attachment.rb on lines 141..149
lib/tasks/attachment.rb on lines 152..160
lib/tasks/attachment.rb on lines 163..171
lib/tasks/attachment.rb on lines 174..182
lib/tasks/attachment.rb on lines 196..204
lib/tasks/attachment.rb on lines 207..215
lib/tasks/attachment.rb on lines 236..244
lib/tasks/attachment.rb on lines 247..255
lib/tasks/attachment.rb on lines 258..266
lib/tasks/attachment.rb on lines 269..277

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

  ResourceExportFile.where.not(resource_export_file_name: nil).find_each do |file|
    file.attachment.attach(
      io: URI(Paperclip::Attachment.new(
        :resource_export,
        file,
Severity: Major
Found in lib/tasks/attachment.rb and 10 other locations - About 15 mins to fix
lib/tasks/attachment.rb on lines 141..149
lib/tasks/attachment.rb on lines 152..160
lib/tasks/attachment.rb on lines 163..171
lib/tasks/attachment.rb on lines 174..182
lib/tasks/attachment.rb on lines 185..193
lib/tasks/attachment.rb on lines 196..204
lib/tasks/attachment.rb on lines 207..215
lib/tasks/attachment.rb on lines 247..255
lib/tasks/attachment.rb on lines 258..266
lib/tasks/attachment.rb on lines 269..277

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 35 locations. Consider refactoring.
Open

  def destroy
    @budget_type.destroy

    respond_to do |format|
      format.html { redirect_to budget_types_url, notice: t('controller.successfully_deleted', model: t('activerecord.models.budget_type')) }
Severity: Major
Found in app/controllers/budget_types_controller.rb and 34 other locations - About 15 mins to fix
app/controllers/accepts_controller.rb on lines 105..110
app/controllers/agent_import_files_controller.rb on lines 71..76
app/controllers/agent_import_results_controller.rb on lines 33..38
app/controllers/agent_relationship_types_controller.rb on lines 69..74
app/controllers/agent_types_controller.rb on lines 69..74
app/controllers/agents_controller.rb on lines 181..186
app/controllers/bookstores_controller.rb on lines 69..74
app/controllers/carrier_types_controller.rb on lines 76..81
app/controllers/classification_types_controller.rb on lines 69..74
app/controllers/content_types_controller.rb on lines 69..74
app/controllers/countries_controller.rb on lines 69..74
app/controllers/create_types_controller.rb on lines 69..74
app/controllers/event_categories_controller.rb on lines 69..74
app/controllers/event_import_results_controller.rb on lines 31..36
app/controllers/form_of_works_controller.rb on lines 69..74
app/controllers/frequencies_controller.rb on lines 69..74
app/controllers/identifier_types_controller.rb on lines 69..74
app/controllers/import_requests_controller.rb on lines 85..90
app/controllers/languages_controller.rb on lines 69..74
app/controllers/licenses_controller.rb on lines 69..74
app/controllers/manifestation_relationship_types_controller.rb on lines 69..74
app/controllers/medium_of_performances_controller.rb on lines 69..74
app/controllers/nii_types_controller.rb on lines 69..74
app/controllers/produce_types_controller.rb on lines 69..74
app/controllers/profiles_controller.rb on lines 146..151
app/controllers/realize_types_controller.rb on lines 69..74
app/controllers/resource_import_files_controller.rb on lines 77..82
app/controllers/resource_import_results_controller.rb on lines 35..40
app/controllers/search_engines_controller.rb on lines 69..74
app/controllers/subject_heading_types_controller.rb on lines 69..74
app/controllers/subject_types_controller.rb on lines 69..74
app/controllers/subjects_controller.rb on lines 115..120
app/controllers/user_import_results_controller.rb on lines 31..36
app/controllers/withdraws_controller.rb on lines 106..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 35 locations. Consider refactoring.
Open

  def destroy
    @accept.destroy

    respond_to do |format|
      format.html { redirect_to accepts_url, notice: t('controller.successfully_deleted', model: t('activerecord.models.accept')) }
Severity: Major
Found in app/controllers/accepts_controller.rb and 34 other locations - About 15 mins to fix
app/controllers/agent_import_files_controller.rb on lines 71..76
app/controllers/agent_import_results_controller.rb on lines 33..38
app/controllers/agent_relationship_types_controller.rb on lines 69..74
app/controllers/agent_types_controller.rb on lines 69..74
app/controllers/agents_controller.rb on lines 181..186
app/controllers/bookstores_controller.rb on lines 69..74
app/controllers/budget_types_controller.rb on lines 69..74
app/controllers/carrier_types_controller.rb on lines 76..81
app/controllers/classification_types_controller.rb on lines 69..74
app/controllers/content_types_controller.rb on lines 69..74
app/controllers/countries_controller.rb on lines 69..74
app/controllers/create_types_controller.rb on lines 69..74
app/controllers/event_categories_controller.rb on lines 69..74
app/controllers/event_import_results_controller.rb on lines 31..36
app/controllers/form_of_works_controller.rb on lines 69..74
app/controllers/frequencies_controller.rb on lines 69..74
app/controllers/identifier_types_controller.rb on lines 69..74
app/controllers/import_requests_controller.rb on lines 85..90
app/controllers/languages_controller.rb on lines 69..74
app/controllers/licenses_controller.rb on lines 69..74
app/controllers/manifestation_relationship_types_controller.rb on lines 69..74
app/controllers/medium_of_performances_controller.rb on lines 69..74
app/controllers/nii_types_controller.rb on lines 69..74
app/controllers/produce_types_controller.rb on lines 69..74
app/controllers/profiles_controller.rb on lines 146..151
app/controllers/realize_types_controller.rb on lines 69..74
app/controllers/resource_import_files_controller.rb on lines 77..82
app/controllers/resource_import_results_controller.rb on lines 35..40
app/controllers/search_engines_controller.rb on lines 69..74
app/controllers/subject_heading_types_controller.rb on lines 69..74
app/controllers/subject_types_controller.rb on lines 69..74
app/controllers/subjects_controller.rb on lines 115..120
app/controllers/user_import_results_controller.rb on lines 31..36
app/controllers/withdraws_controller.rb on lines 106..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 35 locations. Consider refactoring.
Open

  def destroy
    @user_import_result.destroy

    respond_to do |format|
      format.html { redirect_to user_import_results_url, notice: t('controller.successfully_deleted', model: t('activerecord.models.user_import_result')) }
Severity: Major
Found in app/controllers/user_import_results_controller.rb and 34 other locations - About 15 mins to fix
app/controllers/accepts_controller.rb on lines 105..110
app/controllers/agent_import_files_controller.rb on lines 71..76
app/controllers/agent_import_results_controller.rb on lines 33..38
app/controllers/agent_relationship_types_controller.rb on lines 69..74
app/controllers/agent_types_controller.rb on lines 69..74
app/controllers/agents_controller.rb on lines 181..186
app/controllers/bookstores_controller.rb on lines 69..74
app/controllers/budget_types_controller.rb on lines 69..74
app/controllers/carrier_types_controller.rb on lines 76..81
app/controllers/classification_types_controller.rb on lines 69..74
app/controllers/content_types_controller.rb on lines 69..74
app/controllers/countries_controller.rb on lines 69..74
app/controllers/create_types_controller.rb on lines 69..74
app/controllers/event_categories_controller.rb on lines 69..74
app/controllers/event_import_results_controller.rb on lines 31..36
app/controllers/form_of_works_controller.rb on lines 69..74
app/controllers/frequencies_controller.rb on lines 69..74
app/controllers/identifier_types_controller.rb on lines 69..74
app/controllers/import_requests_controller.rb on lines 85..90
app/controllers/languages_controller.rb on lines 69..74
app/controllers/licenses_controller.rb on lines 69..74
app/controllers/manifestation_relationship_types_controller.rb on lines 69..74
app/controllers/medium_of_performances_controller.rb on lines 69..74
app/controllers/nii_types_controller.rb on lines 69..74
app/controllers/produce_types_controller.rb on lines 69..74
app/controllers/profiles_controller.rb on lines 146..151
app/controllers/realize_types_controller.rb on lines 69..74
app/controllers/resource_import_files_controller.rb on lines 77..82
app/controllers/resource_import_results_controller.rb on lines 35..40
app/controllers/search_engines_controller.rb on lines 69..74
app/controllers/subject_heading_types_controller.rb on lines 69..74
app/controllers/subject_types_controller.rb on lines 69..74
app/controllers/subjects_controller.rb on lines 115..120
app/controllers/withdraws_controller.rb on lines 106..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

  ResourceExportFile.where.not(resource_export_file_name: nil).find_each do |file|
    file.attachment.attach(
      io: File.open(Paperclip::Attachment.new(
        :resource_export,
        file,
Severity: Major
Found in lib/tasks/attachment.rb and 10 other locations - About 15 mins to fix
lib/tasks/attachment.rb on lines 6..14
lib/tasks/attachment.rb on lines 17..25
lib/tasks/attachment.rb on lines 28..36
lib/tasks/attachment.rb on lines 39..47
lib/tasks/attachment.rb on lines 50..58
lib/tasks/attachment.rb on lines 61..69
lib/tasks/attachment.rb on lines 72..80
lib/tasks/attachment.rb on lines 106..114
lib/tasks/attachment.rb on lines 117..125
lib/tasks/attachment.rb on lines 128..136

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 35 locations. Consider refactoring.
Open

  def destroy
    @agent_relationship_type.destroy

    respond_to do |format|
      format.html { redirect_to agent_relationship_types_url, notice: t('controller.successfully_deleted', model: t('activerecord.models.agent_relationship_type')) }
Severity: Major
Found in app/controllers/agent_relationship_types_controller.rb and 34 other locations - About 15 mins to fix
app/controllers/accepts_controller.rb on lines 105..110
app/controllers/agent_import_files_controller.rb on lines 71..76
app/controllers/agent_import_results_controller.rb on lines 33..38
app/controllers/agent_types_controller.rb on lines 69..74
app/controllers/agents_controller.rb on lines 181..186
app/controllers/bookstores_controller.rb on lines 69..74
app/controllers/budget_types_controller.rb on lines 69..74
app/controllers/carrier_types_controller.rb on lines 76..81
app/controllers/classification_types_controller.rb on lines 69..74
app/controllers/content_types_controller.rb on lines 69..74
app/controllers/countries_controller.rb on lines 69..74
app/controllers/create_types_controller.rb on lines 69..74
app/controllers/event_categories_controller.rb on lines 69..74
app/controllers/event_import_results_controller.rb on lines 31..36
app/controllers/form_of_works_controller.rb on lines 69..74
app/controllers/frequencies_controller.rb on lines 69..74
app/controllers/identifier_types_controller.rb on lines 69..74
app/controllers/import_requests_controller.rb on lines 85..90
app/controllers/languages_controller.rb on lines 69..74
app/controllers/licenses_controller.rb on lines 69..74
app/controllers/manifestation_relationship_types_controller.rb on lines 69..74
app/controllers/medium_of_performances_controller.rb on lines 69..74
app/controllers/nii_types_controller.rb on lines 69..74
app/controllers/produce_types_controller.rb on lines 69..74
app/controllers/profiles_controller.rb on lines 146..151
app/controllers/realize_types_controller.rb on lines 69..74
app/controllers/resource_import_files_controller.rb on lines 77..82
app/controllers/resource_import_results_controller.rb on lines 35..40
app/controllers/search_engines_controller.rb on lines 69..74
app/controllers/subject_heading_types_controller.rb on lines 69..74
app/controllers/subject_types_controller.rb on lines 69..74
app/controllers/subjects_controller.rb on lines 115..120
app/controllers/user_import_results_controller.rb on lines 31..36
app/controllers/withdraws_controller.rb on lines 106..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language