Sign upLogin

nexxtway/react-rainbow

View on GitHub
Star
integration/specs/CarouselCard/carouselCard.spec.js

Summary

Maintainability
D
2 days
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    it('should select the last indicator when the first has focus and left arrow key is pressed', async () => {
        const carousel = new PageCarouselCard(CAROUSEL);
        const indicator = await carousel.getIndicatorItem(0);
        await indicator.click();
        await browser.keys('ArrowLeft');
Severity: Major
Found in integration/specs/CarouselCard/carouselCard.spec.js and 2 other locations - About 3 hrs to fix
integration/specs/CarouselCard/carouselCard.spec.js on lines 29..36
integration/specs/CarouselCard/carouselCard.spec.js on lines 37..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    it('should select the first indicator when the last has focus and right arrow key is pressed', async () => {
        const carousel = new PageCarouselCard(CAROUSEL);
        const indicator = await carousel.getIndicatorItem(2);
        await indicator.click();
        await browser.keys('ArrowRight');
Severity: Major
Found in integration/specs/CarouselCard/carouselCard.spec.js and 2 other locations - About 3 hrs to fix
integration/specs/CarouselCard/carouselCard.spec.js on lines 21..28
integration/specs/CarouselCard/carouselCard.spec.js on lines 29..36

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    it('should select the next indicator when the first has focus and right arrow key is pressed', async () => {
        const carousel = new PageCarouselCard(CAROUSEL);
        const indicator = await carousel.getIndicatorItem(0);
        await indicator.click();
        await browser.keys('ArrowRight');
Severity: Major
Found in integration/specs/CarouselCard/carouselCard.spec.js and 2 other locations - About 3 hrs to fix
integration/specs/CarouselCard/carouselCard.spec.js on lines 21..28
integration/specs/CarouselCard/carouselCard.spec.js on lines 37..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    it('should loose focus if other indicator is selected', async () => {
        const carousel = new PageCarouselCard(CAROUSEL);
        const indicator = await carousel.getIndicatorItem(0);
        const indicator2 = await carousel.getIndicatorItem(1);
        await indicator.click();
Severity: Major
Found in integration/specs/CarouselCard/carouselCard.spec.js and 6 other locations - About 3 hrs to fix
integration/specs/CheckboxGroup/checkboxGroup-1.spec.js on lines 22..29
integration/specs/CheckboxGroup/checkboxGroup-1.spec.js on lines 44..51
integration/specs/Tabset/tabset-1.spec.js on lines 38..45
integration/specs/VisualPicker/visualPicker-1.spec.js on lines 21..28
integration/specs/VisualPicker/visualPicker-1.spec.js on lines 35..42
integration/specs/VisualPicker/visualPicker-3.spec.js on lines 20..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    it('should loose focus if other indicator is selected by keyboard navigation', async () => {
        const carousel = new PageCarouselCard(CAROUSEL);
        const indicator = await carousel.getIndicatorItem(0);
        await indicator.click();
        await browser.keys('ArrowRight');
Severity: Major
Found in integration/specs/CarouselCard/carouselCard.spec.js and 2 other locations - About 2 hrs to fix
integration/specs/ButtonGroupPicker/buttonGroupPicker-1.spec.js on lines 47..53
integration/specs/ButtonGroupPicker/buttonGroupPicker-1.spec.js on lines 73..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 22 locations. Consider refactoring.
Open

    it('should select the first indicator when selected', async () => {
        const carousel = new PageCarouselCard(CAROUSEL);
        const carouselIem = await carousel.getIndicatorItem(0);
        await carouselIem.click();
        await expect(await carouselIem.isSelected()).toBe(true);
Severity: Major
Found in integration/specs/CarouselCard/carouselCard.spec.js and 21 other locations - About 2 hrs to fix
integration/specs/Accordion/accordion-1.spec.js on lines 16..21
integration/specs/Accordion/accordion-5.spec.js on lines 15..20
integration/specs/ButtonGroupPicker/buttonGroupPicker-1.spec.js on lines 15..20
integration/specs/ButtonGroupPicker/buttonGroupPicker-1.spec.js on lines 22..27
integration/specs/ButtonGroupPicker/buttonGroupPicker-3.spec.js on lines 24..29
integration/specs/ButtonGroupPicker/buttonGroupPicker-5.spec.js on lines 15..20
integration/specs/ButtonGroupPicker/buttonGroupPicker-5.spec.js on lines 22..27
integration/specs/CheckboxGroup/checkboxGroup-1.spec.js on lines 16..21
integration/specs/CheckboxGroup/checkboxGroup-1.spec.js on lines 38..43
integration/specs/InternalDropdown/internalDropdown-1.spec.js on lines 65..70
integration/specs/RadioButtonGroup/radioButtonGroup-1.spec.js on lines 16..21
integration/specs/RadioButtonGroup/radioButtonGroup-1.spec.js on lines 37..42
integration/specs/RadioGroup/radioGroup-1.spec.js on lines 15..20
integration/specs/RadioGroup/radioGroup-1.spec.js on lines 38..43
integration/specs/Sidebar/sidebar-1.spec.js on lines 16..21
integration/specs/Tabset/tabset-1.spec.js on lines 16..21
integration/specs/VerticalNavigation/verticalNavigation-11.spec.js on lines 23..28
integration/specs/VisualPicker/visualPicker-1.spec.js on lines 15..20
integration/specs/VisualPicker/visualPicker-1.spec.js on lines 29..34
integration/specs/VisualPicker/visualPicker-3.spec.js on lines 14..19
integration/specs/VisualPicker/visualPicker-3.spec.js on lines 28..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status