nexxtway/react-rainbow

View on GitHub
integration/specs/VisualPicker/visualPicker-3.spec.js

Summary

Maintainability
D
1 day
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('should not loose the checked if another option is clicked', async () => {
        const visualPicker = new PageVisualPicker(VISUAL_PICKER);
        const option1 = await visualPicker.getItem(0);
        const option3 = await visualPicker.getItem(2);
        await option1.click();
Severity: Major
Found in integration/specs/VisualPicker/visualPicker-3.spec.js and 1 other location - About 4 hrs to fix
integration/specs/Accordion/accordion-1.spec.js on lines 29..37

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 134.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    it('should loose focus if another option is clicked', async () => {
        const visualPicker = new PageVisualPicker(VISUAL_PICKER);
        const option1 = await visualPicker.getItem(0);
        const option3 = await visualPicker.getItem(2);
        await option1.click();
Severity: Major
Found in integration/specs/VisualPicker/visualPicker-3.spec.js and 6 other locations - About 3 hrs to fix
integration/specs/CarouselCard/carouselCard.spec.js on lines 45..52
integration/specs/CheckboxGroup/checkboxGroup-1.spec.js on lines 22..29
integration/specs/CheckboxGroup/checkboxGroup-1.spec.js on lines 44..51
integration/specs/Tabset/tabset-1.spec.js on lines 38..45
integration/specs/VisualPicker/visualPicker-1.spec.js on lines 21..28
integration/specs/VisualPicker/visualPicker-1.spec.js on lines 35..42

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 22 locations. Consider refactoring.
Open

    it('should set checked on the option when clicked', async () => {
        const visualPicker = new PageVisualPicker(VISUAL_PICKER);
        const option = await visualPicker.getItem(0);
        await option.click();
        await expect(await option.isChecked()).toBe(true);
Severity: Major
Found in integration/specs/VisualPicker/visualPicker-3.spec.js and 21 other locations - About 2 hrs to fix
integration/specs/Accordion/accordion-1.spec.js on lines 16..21
integration/specs/Accordion/accordion-5.spec.js on lines 15..20
integration/specs/ButtonGroupPicker/buttonGroupPicker-1.spec.js on lines 15..20
integration/specs/ButtonGroupPicker/buttonGroupPicker-1.spec.js on lines 22..27
integration/specs/ButtonGroupPicker/buttonGroupPicker-3.spec.js on lines 24..29
integration/specs/ButtonGroupPicker/buttonGroupPicker-5.spec.js on lines 15..20
integration/specs/ButtonGroupPicker/buttonGroupPicker-5.spec.js on lines 22..27
integration/specs/CarouselCard/carouselCard.spec.js on lines 15..20
integration/specs/CheckboxGroup/checkboxGroup-1.spec.js on lines 16..21
integration/specs/CheckboxGroup/checkboxGroup-1.spec.js on lines 38..43
integration/specs/InternalDropdown/internalDropdown-1.spec.js on lines 65..70
integration/specs/RadioButtonGroup/radioButtonGroup-1.spec.js on lines 16..21
integration/specs/RadioButtonGroup/radioButtonGroup-1.spec.js on lines 37..42
integration/specs/RadioGroup/radioGroup-1.spec.js on lines 15..20
integration/specs/RadioGroup/radioGroup-1.spec.js on lines 38..43
integration/specs/Sidebar/sidebar-1.spec.js on lines 16..21
integration/specs/Tabset/tabset-1.spec.js on lines 16..21
integration/specs/VerticalNavigation/verticalNavigation-11.spec.js on lines 23..28
integration/specs/VisualPicker/visualPicker-1.spec.js on lines 15..20
integration/specs/VisualPicker/visualPicker-1.spec.js on lines 29..34
integration/specs/VisualPicker/visualPicker-3.spec.js on lines 14..19

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 22 locations. Consider refactoring.
Open

    it(' set the focus on the item clicked', async () => {
        const visualPicker = new PageVisualPicker(VISUAL_PICKER);
        const option = await visualPicker.getItem(0);
        await option.click();
        await expect(await option.hasFocus()).toBe(true);
Severity: Major
Found in integration/specs/VisualPicker/visualPicker-3.spec.js and 21 other locations - About 2 hrs to fix
integration/specs/Accordion/accordion-1.spec.js on lines 16..21
integration/specs/Accordion/accordion-5.spec.js on lines 15..20
integration/specs/ButtonGroupPicker/buttonGroupPicker-1.spec.js on lines 15..20
integration/specs/ButtonGroupPicker/buttonGroupPicker-1.spec.js on lines 22..27
integration/specs/ButtonGroupPicker/buttonGroupPicker-3.spec.js on lines 24..29
integration/specs/ButtonGroupPicker/buttonGroupPicker-5.spec.js on lines 15..20
integration/specs/ButtonGroupPicker/buttonGroupPicker-5.spec.js on lines 22..27
integration/specs/CarouselCard/carouselCard.spec.js on lines 15..20
integration/specs/CheckboxGroup/checkboxGroup-1.spec.js on lines 16..21
integration/specs/CheckboxGroup/checkboxGroup-1.spec.js on lines 38..43
integration/specs/InternalDropdown/internalDropdown-1.spec.js on lines 65..70
integration/specs/RadioButtonGroup/radioButtonGroup-1.spec.js on lines 16..21
integration/specs/RadioButtonGroup/radioButtonGroup-1.spec.js on lines 37..42
integration/specs/RadioGroup/radioGroup-1.spec.js on lines 15..20
integration/specs/RadioGroup/radioGroup-1.spec.js on lines 38..43
integration/specs/Sidebar/sidebar-1.spec.js on lines 16..21
integration/specs/Tabset/tabset-1.spec.js on lines 16..21
integration/specs/VerticalNavigation/verticalNavigation-11.spec.js on lines 23..28
integration/specs/VisualPicker/visualPicker-1.spec.js on lines 15..20
integration/specs/VisualPicker/visualPicker-1.spec.js on lines 29..34
integration/specs/VisualPicker/visualPicker-3.spec.js on lines 28..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status