nexxtway/react-rainbow

View on GitHub
src/components/Breadcrumb/__test__/breadcrumb.spec.js

Summary

Maintainability
B
6 hrs
Test Coverage

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    it('should render an anchor when href is passed', () => {
        const component = mount(<Breadcrumb label="index" href="index" />);

        expect(component.find('a').exists()).toBe(true);
    });
Severity: Major
Found in src/components/Breadcrumb/__test__/breadcrumb.spec.js and 3 other locations - About 1 hr to fix
src/components/Table/body/__test__/cell.spec.js on lines 40..43
src/components/Table/body/__test__/cell.spec.js on lines 44..47
src/components/Table/body/__test__/cell.spec.js on lines 48..51

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('should set the label passed as children while href is passed', () => {
        const component = mount(<Breadcrumb href="index" label="index" />);

        expect(component.find('a').text()).toBe('index');
    });
Severity: Major
Found in src/components/Breadcrumb/__test__/breadcrumb.spec.js and 1 other location - About 1 hr to fix
src/components/VerticalItem/__test__/verticalItem.spec.js on lines 71..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    it('should set the right aria-disabled value when the disabled is passed', () => {
        const component = mount(<Breadcrumb label="index" disabled />);

        expect(component.find('button').prop('aria-disabled')).toBe(true);
    });
Severity: Major
Found in src/components/Breadcrumb/__test__/breadcrumb.spec.js and 6 other locations - About 1 hr to fix
src/components/Button/__test__/button.spec.js on lines 25..29
src/components/Button/__test__/button.spec.js on lines 45..49
src/components/Button/__test__/button.spec.js on lines 59..63
src/components/Input/label/__test__/label.spec.js on lines 18..21
src/components/Select/__test__/select.spec.js on lines 28..31
src/components/Table/head/__test__/header.spec.js on lines 47..50

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 15 locations. Consider refactoring.
Open

    it('should render a button when href is not passed', () => {
        const component = mount(<Breadcrumb label="index" />);

        expect(component.find('button').exists()).toBe(true);
    });
Severity: Major
Found in src/components/Breadcrumb/__test__/breadcrumb.spec.js and 14 other locations - About 1 hr to fix
src/components/AssistiveText/__test__/assistiveText.spec.js on lines 6..9
src/components/Avatar/__test__/avatarContent.spec.js on lines 7..10
src/components/Avatar/__test__/avatarContent.spec.js on lines 19..22
src/components/GMap/__test__/component.spec.js on lines 28..31
src/components/ImportRecordsFlow/stepOne/__test__/stepOne.spec.js on lines 9..12
src/components/ImportRecordsFlow/stepOne/__test__/stepOne.spec.js on lines 13..16
src/components/Input/__test__/input.spec.js on lines 6..9
src/components/Input/__test__/input.spec.js on lines 10..13
src/components/Notification/__test__/icon.spec.js on lines 10..13
src/components/Notification/__test__/icon.spec.js on lines 14..17
src/components/Notification/__test__/icon.spec.js on lines 18..21
src/components/Notification/__test__/icon.spec.js on lines 22..25
src/components/Notification/__test__/icon.spec.js on lines 27..30
src/components/TimePicker/__test__/ampmSelect.spec.js on lines 6..9

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status