Sign upLogin

nexxtway/react-rainbow

View on GitHub
Star
src/components/ButtonGroupPicker/__test__/buttonGroupPicker.spec.js

Summary

Maintainability
C
1 day
Test Coverage

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    it('should pass the right props to the Label component', () => {
        const component = mount(<ButtonGroupPicker label="custom label" required />);
        expect(component.find('Label').props()).toEqual({
            label: 'custom label',
            required: true,
Severity: Major
Found in src/components/ButtonGroupPicker/__test__/buttonGroupPicker.spec.js and 3 other locations - About 3 hrs to fix
src/components/CodeInput/__test__/codeInput.spec.js on lines 26..38
src/components/VisualPicker/__test__/visualPicker.spec.js on lines 82..94
src/components/WeekDayPicker/__test__/weekDayPicker.spec.js on lines 12..24

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        const component = mount(
            <ButtonGroupPicker value={value} onChange={onChangeFn} multiple>
                <ButtonOption label="Option 1" name="option1" />
                <ButtonOption label="Option 2" name="option2" />
            </ButtonGroupPicker>,
Severity: Major
Found in src/components/ButtonGroupPicker/__test__/buttonGroupPicker.spec.js and 1 other location - About 2 hrs to fix
src/components/ButtonGroupPicker/__test__/buttonGroupPicker.spec.js on lines 113..118

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        const component = mount(
            <ButtonGroupPicker value={value} onChange={onChangeFn} multiple>
                <ButtonOption label="Option 1" name="option1" />
                <ButtonOption label="Option 2" name="option2" />
            </ButtonGroupPicker>,
Severity: Major
Found in src/components/ButtonGroupPicker/__test__/buttonGroupPicker.spec.js and 1 other location - About 2 hrs to fix
src/components/ButtonGroupPicker/__test__/buttonGroupPicker.spec.js on lines 82..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    it('should render required asterisk when required prop is true', () => {
        const component = mount(<ButtonGroupPicker label="My label" required />);
        expect(component.find('RequiredAsterisk').exists()).toBe(true);
    });
Severity: Major
Found in src/components/ButtonGroupPicker/__test__/buttonGroupPicker.spec.js and 2 other locations - About 1 hr to fix
src/components/Slider/__test__/slider.spec.js on lines 69..72
src/components/WeekDayPicker/__test__/weekDayPicker.spec.js on lines 29..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 17 locations. Consider refactoring.
Open

    it('should render an error text when error prop is passed', () => {
        const component = mount(<ButtonGroupPicker error="error" />);
        expect(component.find(StyledErrorText).exists()).toBe(true);
    });
Severity: Major
Found in src/components/ButtonGroupPicker/__test__/buttonGroupPicker.spec.js and 16 other locations - About 1 hr to fix
src/components/ButtonIcon/__test__/buttonIcon.spec.js on lines 65..68
src/components/CheckboxGroup/__test__/checkboxGroup.spec.js on lines 55..58
src/components/CodeInput/__test__/codeInput.spec.js on lines 39..42
src/components/CodeInput/__test__/codeInput.spec.js on lines 47..50
src/components/FileSelector/__test__/fileSelector.spec.js on lines 57..60
src/components/Input/pickerInput/__test__/input.spec.js on lines 82..85
src/components/MultiSelect/__test__/multiSelect.spec.js on lines 12..15
src/components/MultiSelect/__test__/multiSelect.spec.js on lines 17..20
src/components/MultiSelect/__test__/multiSelect.spec.js on lines 22..25
src/components/MultiSelect/__test__/multiSelect.spec.js on lines 27..30
src/components/Option/__test__/option.spec.js on lines 131..134
src/components/RadioButtonGroup/__test__/radioButtonGroup.spec.js on lines 60..63
src/components/RadioGroup/__test__/radioGroup.spec.js on lines 39..42
src/components/Rating/__test__/rating.spec.js on lines 20..23
src/components/Slider/__test__/slider.spec.js on lines 34..37
src/components/WeekDayPicker/__test__/weekDayPicker.spec.js on lines 51..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status