Sign upLogin

nexxtway/react-rainbow

View on GitHub
Star
src/components/Calendar/__test__/calendar.spec.js

Summary

Maintainability
D
3 days
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('should fire onChange with a date as parameter when selectionType is single', () => {
        const value = new Date('04/24/2019');
        const mockChangeFn = jest.fn();
        const simpleCalendar = mount(<Calendar value={value} onChange={mockChangeFn} />);
        simpleCalendar
Severity: Major
Found in src/components/Calendar/__test__/calendar.spec.js and 1 other location - About 4 hrs to fix
src/components/Calendar/doubleCalendar/__test__/doubleCalendar.spec.js on lines 99..109

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 123.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    it('should set to disable the next month button when maxDate is less than next month date', () => {
        const value = new Date('04/24/2019');
        const maxDate = new Date('04/30/2019');
        const component = mount(<Calendar value={value} maxDate={maxDate} />);
        const prevMonthButton = component.find(ButtonIcon).at(1);
Severity: Major
Found in src/components/Calendar/__test__/calendar.spec.js and 7 other locations - About 3 hrs to fix
src/components/Calendar/__test__/calendar.spec.js on lines 33..39
src/components/Calendar/doubleCalendar/__test__/doubleCalendar.spec.js on lines 66..72
src/components/Calendar/doubleCalendar/__test__/doubleCalendar.spec.js on lines 73..79
src/components/MonthlyCalendar/__test__/monthlyCalendar.spec.js on lines 19..25
src/components/MonthlyCalendar/__test__/monthlyCalendar.spec.js on lines 26..32
src/components/WeeklyCalendar/__test__/weeklyCalendar.spec.js on lines 19..25
src/components/WeeklyCalendar/__test__/weeklyCalendar.spec.js on lines 26..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    it('should set to disable the prev month button when minDate is greater than prev month date', () => {
        const value = new Date('04/24/2019');
        const minDate = new Date('04/01/2019');
        const component = mount(<Calendar value={value} minDate={minDate} />);
        const prevMonthButton = component.find(ButtonIcon).at(0);
Severity: Major
Found in src/components/Calendar/__test__/calendar.spec.js and 7 other locations - About 3 hrs to fix
src/components/Calendar/__test__/calendar.spec.js on lines 40..46
src/components/Calendar/doubleCalendar/__test__/doubleCalendar.spec.js on lines 66..72
src/components/Calendar/doubleCalendar/__test__/doubleCalendar.spec.js on lines 73..79
src/components/MonthlyCalendar/__test__/monthlyCalendar.spec.js on lines 19..25
src/components/MonthlyCalendar/__test__/monthlyCalendar.spec.js on lines 26..32
src/components/WeeklyCalendar/__test__/weeklyCalendar.spec.js on lines 19..25
src/components/WeeklyCalendar/__test__/weeklyCalendar.spec.js on lines 26..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('should render the prev month', () => {
        const value = new Date('04/24/2019');
        const component = mount(<Calendar value={value} />);
        const prevMonthButton = component.find(ButtonIcon).at(0);
        prevMonthButton.simulate('click');
Severity: Major
Found in src/components/Calendar/__test__/calendar.spec.js and 1 other location - About 3 hrs to fix
src/components/Calendar/__test__/calendar.spec.js on lines 26..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('should render the next month', () => {
        const value = new Date('04/24/2019');
        const component = mount(<Calendar value={value} />);
        const nextMonthButton = component.find(ButtonIcon).at(1);
        nextMonthButton.simulate('click');
Severity: Major
Found in src/components/Calendar/__test__/calendar.spec.js and 1 other location - About 3 hrs to fix
src/components/Calendar/__test__/calendar.spec.js on lines 19..25

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    it('should render the component when pass falsy values', () => {
        const values = ['', undefined, null, 0];
        values.forEach(value => {
            const component = mount(<Calendar value={value} />);
            expect(component.exists()).toBe(true);
Severity: Major
Found in src/components/Calendar/__test__/calendar.spec.js and 3 other locations - About 2 hrs to fix
src/components/Calendar/doubleCalendar/__test__/doubleCalendar.spec.js on lines 7..13
src/components/MonthlyCalendar/__test__/monthlyCalendar.spec.js on lines 7..13
src/components/WeeklyCalendar/__test__/weeklyCalendar.spec.js on lines 7..13

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    it('should render the right month', () => {
        const value = new Date('04/24/2019');
        const component = mount(<Calendar value={value} />);
        expect(component.find('h3[data-id="month"]').text()).toBe('April');
    });
Severity: Major
Found in src/components/Calendar/__test__/calendar.spec.js and 2 other locations - About 2 hrs to fix
src/components/MonthlyCalendar/__test__/monthlyCalendar.spec.js on lines 14..18
src/components/WeeklyCalendar/__test__/weeklyCalendar.spec.js on lines 14..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status