Sign upLogin

nexxtway/react-rainbow

View on GitHub
Star
src/components/GMap/__test__/component.spec.js

Summary

Maintainability
D
1 day
Test Coverage

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        const component = mount(
            <MapComponent latitude={8} longitude={12} zoom={15}>
                <MapMarker latitude={9} longitude={12} />
                <MapMarker latitude={10} longitude={15} />
                <MapMarker latitude={8} longitude={10} />
Severity: Major
Found in src/components/GMap/__test__/component.spec.js and 1 other location - About 3 hrs to fix
src/components/GMap/__test__/component.spec.js on lines 79..85

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        const component = mount(
            <MapComponent latitude={8} longitude={12} zoom={15}>
                <MapMarker latitude={9} longitude={12} />
                <MapMarker latitude={10} longitude={15} />
                <MapMarker latitude={8} longitude={10} />
Severity: Major
Found in src/components/GMap/__test__/component.spec.js and 1 other location - About 3 hrs to fix
src/components/GMap/__test__/component.spec.js on lines 94..100

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('should not call google.maps.Map when isScriptLoaded and isScriptLoadSucceed are false', () => {
        const component = mount(<MapComponent className="some-class" />);
        component.setProps({
            isScriptLoaded: false,
            isScriptLoadSucceed: false,
Severity: Major
Found in src/components/GMap/__test__/component.spec.js and 1 other location - About 2 hrs to fix
src/components/GMap/__test__/component.spec.js on lines 40..47

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('should not call google.maps.Map when isScriptLoaded is true and isScriptLoadSucceed is false', () => {
        const component = mount(<MapComponent className="some-class" />);
        component.setProps({
            isScriptLoaded: true,
            isScriptLoadSucceed: false,
Severity: Major
Found in src/components/GMap/__test__/component.spec.js and 1 other location - About 2 hrs to fix
src/components/GMap/__test__/component.spec.js on lines 32..39

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 15 locations. Consider refactoring.
Open

    it('should have the right class names', () => {
        const component = mount(<MapComponent className="some-class" />);
        expect(component.find('.rainbow-google-map.some-class').exists()).toBe(true);
    });
Severity: Major
Found in src/components/GMap/__test__/component.spec.js and 14 other locations - About 1 hr to fix
src/components/AssistiveText/__test__/assistiveText.spec.js on lines 6..9
src/components/Avatar/__test__/avatarContent.spec.js on lines 7..10
src/components/Avatar/__test__/avatarContent.spec.js on lines 19..22
src/components/Breadcrumb/__test__/breadcrumb.spec.js on lines 12..16
src/components/ImportRecordsFlow/stepOne/__test__/stepOne.spec.js on lines 9..12
src/components/ImportRecordsFlow/stepOne/__test__/stepOne.spec.js on lines 13..16
src/components/Input/__test__/input.spec.js on lines 6..9
src/components/Input/__test__/input.spec.js on lines 10..13
src/components/Notification/__test__/icon.spec.js on lines 10..13
src/components/Notification/__test__/icon.spec.js on lines 14..17
src/components/Notification/__test__/icon.spec.js on lines 18..21
src/components/Notification/__test__/icon.spec.js on lines 22..25
src/components/Notification/__test__/icon.spec.js on lines 27..30
src/components/TimePicker/__test__/ampmSelect.spec.js on lines 6..9

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status