Sign upLogin

nexxtway/react-rainbow

View on GitHub
Star
src/components/Tab/__test__/tab.spec.js

Summary

Maintainability
D
1 day
Test Coverage

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    it('should set id in the button element', () => {
        const component = mount(<Tab privateRegisterTab={() => {}} name="tab-1" id="tab 1" />);
        const button = component.find('button');

        expect(button.prop('id')).toBe('tab 1');
Severity: Major
Found in src/components/Tab/__test__/tab.spec.js and 4 other locations - About 2 hrs to fix
src/components/Tab/__test__/tab.spec.js on lines 33..40
src/components/Tab/__test__/tab.spec.js on lines 49..56
src/components/Tab/__test__/tab.spec.js on lines 87..94
src/components/Tab/__test__/tab.spec.js on lines 126..132

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    it('should set role to tab in button element', () => {
        const component = mount(
            <Tab privateRegisterTab={() => {}} name="tab-1" activeTabName="tab-2" />,
        );
        const button = component.find('button');
Severity: Major
Found in src/components/Tab/__test__/tab.spec.js and 4 other locations - About 2 hrs to fix
src/components/Tab/__test__/tab.spec.js on lines 33..40
src/components/Tab/__test__/tab.spec.js on lines 81..86
src/components/Tab/__test__/tab.spec.js on lines 87..94
src/components/Tab/__test__/tab.spec.js on lines 126..132

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    it('should set role to presentation in li.', () => {
        const component = mount(
            <Tab privateRegisterTab={() => {}} name="tab-1" activeTabName="tab-2" />,
        );
        const listItem = component.find('li');
Severity: Major
Found in src/components/Tab/__test__/tab.spec.js and 4 other locations - About 2 hrs to fix
src/components/Tab/__test__/tab.spec.js on lines 49..56
src/components/Tab/__test__/tab.spec.js on lines 81..86
src/components/Tab/__test__/tab.spec.js on lines 87..94
src/components/Tab/__test__/tab.spec.js on lines 126..132

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    it('should set type to "button" in button element', () => {
        const component = mount(
            <Tab privateRegisterTab={() => {}} name="tab-1" activeTabName="tab-2" />,
        );
        const button = component.find('button');
Severity: Major
Found in src/components/Tab/__test__/tab.spec.js and 4 other locations - About 2 hrs to fix
src/components/Tab/__test__/tab.spec.js on lines 33..40
src/components/Tab/__test__/tab.spec.js on lines 49..56
src/components/Tab/__test__/tab.spec.js on lines 81..86
src/components/Tab/__test__/tab.spec.js on lines 87..94

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    it('should set id in the button element', () => {
        const component = mount(
            <Tab privateRegisterTab={() => {}} name="tab-1" ariaControls="tab-content-1" />,
        );
        const button = component.find('button');
Severity: Major
Found in src/components/Tab/__test__/tab.spec.js and 4 other locations - About 2 hrs to fix
src/components/Tab/__test__/tab.spec.js on lines 33..40
src/components/Tab/__test__/tab.spec.js on lines 49..56
src/components/Tab/__test__/tab.spec.js on lines 81..86
src/components/Tab/__test__/tab.spec.js on lines 126..132

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        const component = mount(
            <Tab
                privateRegisterTab={() => {}}
                label="Tab-1"
                name="tab-1"
Severity: Minor
Found in src/components/Tab/__test__/tab.spec.js and 1 other location - About 35 mins to fix
src/components/Tab/__test__/tab.spec.js on lines 115..122

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        const component = mount(
            <Tab
                privateRegisterTab={() => {}}
                label="Tab-1"
                name="tab-1"
Severity: Minor
Found in src/components/Tab/__test__/tab.spec.js and 1 other location - About 35 mins to fix
src/components/Tab/__test__/tab.spec.js on lines 97..104

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status