Sign upLogin

nexxtway/react-rainbow

View on GitHub
Star
src/libs/manageTab/__test__/findTabbableElements.spec.js

Summary

Maintainability
C
1 day
Test Coverage

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    it('should return an empty array when the are not tabbable nodes but one has a tabindex of -1', () => {
        const dom = new JSDOM(`
            <div>
                <span tabindex="-1"></span>
            </div>
Severity: Major
Found in src/libs/manageTab/__test__/findTabbableElements.spec.js and 4 other locations - About 2 hrs to fix
src/libs/manageTab/__test__/findTabbableElements.spec.js on lines 7..25
src/libs/manageTab/__test__/findTabbableElements.spec.js on lines 26..38
src/libs/manageTab/__test__/findTabbableElements.spec.js on lines 39..47
src/libs/manageTab/__test__/findTabbableElements.spec.js on lines 57..72

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    it('should return the 5 tabbable elements', () => {
        const dom = new JSDOM(`
            <div>
                <h1>Modal Header</h1>
                <p>
Severity: Major
Found in src/libs/manageTab/__test__/findTabbableElements.spec.js and 4 other locations - About 2 hrs to fix
src/libs/manageTab/__test__/findTabbableElements.spec.js on lines 26..38
src/libs/manageTab/__test__/findTabbableElements.spec.js on lines 39..47
src/libs/manageTab/__test__/findTabbableElements.spec.js on lines 48..56
src/libs/manageTab/__test__/findTabbableElements.spec.js on lines 57..72

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    it('should return an empty array when the are not tabbable elements', () => {
        const dom = new JSDOM(`
            <div>
                <h1>Modal Header</h1>
                <p>
Severity: Major
Found in src/libs/manageTab/__test__/findTabbableElements.spec.js and 4 other locations - About 2 hrs to fix
src/libs/manageTab/__test__/findTabbableElements.spec.js on lines 7..25
src/libs/manageTab/__test__/findTabbableElements.spec.js on lines 39..47
src/libs/manageTab/__test__/findTabbableElements.spec.js on lines 48..56
src/libs/manageTab/__test__/findTabbableElements.spec.js on lines 57..72

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    it('should return only 1 tabbable element when there are two but one is disabled', () => {
        const dom = new JSDOM(`
            <div>
                <h1>Modal Header</h1>
                <p>
Severity: Major
Found in src/libs/manageTab/__test__/findTabbableElements.spec.js and 4 other locations - About 2 hrs to fix
src/libs/manageTab/__test__/findTabbableElements.spec.js on lines 7..25
src/libs/manageTab/__test__/findTabbableElements.spec.js on lines 26..38
src/libs/manageTab/__test__/findTabbableElements.spec.js on lines 39..47
src/libs/manageTab/__test__/findTabbableElements.spec.js on lines 48..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    it('should return one element when there is not tabbable nodes but one has a tabindex of 0', () => {
        const dom = new JSDOM(`
            <div>
                <span tabindex="0"></span>
            </div>
Severity: Major
Found in src/libs/manageTab/__test__/findTabbableElements.spec.js and 4 other locations - About 2 hrs to fix
src/libs/manageTab/__test__/findTabbableElements.spec.js on lines 7..25
src/libs/manageTab/__test__/findTabbableElements.spec.js on lines 26..38
src/libs/manageTab/__test__/findTabbableElements.spec.js on lines 48..56
src/libs/manageTab/__test__/findTabbableElements.spec.js on lines 57..72

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status