nilbus/handoff

View on GitHub

Showing 4 of 4 total issues

Method initialize has 12 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def initialize(id, value, status, prescriber, written_date, dosage_value, dosage_units, dosage_text, dispense_quantity, dispense_repeats, coding_system, code)
Severity: Major
Found in app/models/medication.rb - About 1 hr to fix

    Method initialize has 11 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def initialize(display, id, value, units, comment, date, status, reliability, code_system, code, code_display)
    Severity: Major
    Found in app/models/observation.rb - About 1 hr to fix

      Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def initialize(id, value, onset_date, status, code_system, code)
      Severity: Minor
      Found in app/models/condition.rb - About 45 mins to fix

        Method get has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def get(array_location, *path)
              path.reduce(assessment) do |location, key|
                if location && location.is_a?(Hash)
                  location[key]
                elsif location && location.kind_of?(Array) && location.length > 0
        Severity: Minor
        Found in app/models/api/response_data.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language