nilbus/pinewood-derby

View on GitHub

Showing 2 of 4 total issues

Method fill_lineup has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def fill_lineup(options = {})
      upcoming_incomplete.readonly(false).destroy_all
      races_to_queue = options.fetch(:races, 3)
      contestants_per_heat = DerbyConfig.lane_count
      races_to_queue.times do
Severity: Minor
Found in app/models/heat.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method next_suitable has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def self.next_suitable(options = {})
    exclude = Array(options[:exclude])
    exclude = [Contestant.new] if exclude.empty?
    exclude = exclude.map { |contestant| contestant.respond_to?(:id) ? contestant.id.to_i : contestant.to_i }
    lane = options[:lane].to_i
Severity: Minor
Found in app/models/contestant.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language