Sign upLogin

niteshpatel/habitica-slack

View on GitHub
Star

Showing 4 of 6 total issues

Function sync_message_to_habitica has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

def sync_message_to_habitica(request):
    fields = json.loads(request.body)

    if fields.get('type') == 'url_verification':
        challenge = fields.get('challenge')
Severity: Minor
Found in habitica_slack/views.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function send_messages_to_slack has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

def send_messages_to_slack(messages, from_timestamp):
    slack_url = os.environ['SLACK_WEBHOOK']

    last_timestamp = None
    for m in reversed(messages):
Severity: Minor
Found in habitica_slack/actions.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    return HttpResponse('unauthorized request', status=401)
Severity: Major
Found in habitica_slack/views.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return HttpResponse('', status=200)
    Severity: Major
    Found in habitica_slack/views.py - About 30 mins to fix
      Severity
      Category
      Status
      Source
      Language