Sign upLogin

njomeau/zuluzulu

View on GitHub
Star

Showing 46 of 77 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Test
    public void filterWithDateDontAddAnEventInEventFilteredList() {
        onView(withId(R.id.event_fragment_from_date)).perform(click());
        onView(withClassName(Matchers.equalTo(DatePicker.class.getName()))).perform(PickerActions.setDate(2001, 1, 1));
        onView(withText("OK")).perform(click());
Severity: Major
Found in app/src/androidTest/java/ch/epfl/sweng/zuluzulu/fragments/EventFragmentAuthTest.java and 1 other location - About 2 hrs to fix
app/src/androidTest/java/ch/epfl/sweng/zuluzulu/fragments/EventFragmentAuthTest.java on lines 145..154

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 131.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Test
    public void filterWithDateAddAnEventInEventFilteredList() {
        onView(withId(R.id.event_fragment_from_date)).perform(click());
        onView(withClassName(Matchers.equalTo(DatePicker.class.getName()))).perform(PickerActions.setDate(2017, 1, 1));
        onView(withText("OK")).perform(click());
Severity: Major
Found in app/src/androidTest/java/ch/epfl/sweng/zuluzulu/fragments/EventFragmentAuthTest.java and 1 other location - About 2 hrs to fix
app/src/androidTest/java/ch/epfl/sweng/zuluzulu/fragments/EventFragmentAuthTest.java on lines 156..165

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 131.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                } else {
                    auth.addFollowedEvent(data.getId());
                    auth.addFollowedChannel(data.getChannelId());
                    data.addFollower(user.getSciper());
                    DatabaseFactory.getDependency().addEventToUserFollowedEvents(data, auth);
Severity: Major
Found in app/src/main/java/ch/epfl/sweng/zuluzulu/fragments/EventDetailFragment.java and 1 other location - About 1 hr to fix
app/src/main/java/ch/epfl/sweng/zuluzulu/fragments/EventDetailFragment.java on lines 154..162

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                if (auth.isFollowedEvent(data.getId())) {
                    auth.removeFollowedEvent(data.getId());
                    auth.removeFollowedChannel(data.getChannelId());
                    data.removeFollower(user.getSciper());
                    DatabaseFactory.getDependency().removeEventFromUserFollowedEvents(data, auth);
Severity: Major
Found in app/src/main/java/ch/epfl/sweng/zuluzulu/fragments/EventDetailFragment.java and 1 other location - About 1 hr to fix
app/src/main/java/ch/epfl/sweng/zuluzulu/fragments/EventDetailFragment.java on lines 162..170

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        UrlReader reader = new UrlReader() {
            @Override
            public BufferedReader read(String name) {
                return new BufferedReader(new StringReader("[{\n" +
                        "        \"title\": \"MoveOn - Free dance lessons\"," +
Severity: Major
Found in app/src/androidTest/java/ch/epfl/sweng/zuluzulu/MementoFragmentTest.java and 1 other location - About 1 hr to fix
app/src/androidTest/java/ch/epfl/sweng/zuluzulu/fragments/AdminPanelFragmentAsAdminTest.java on lines 35..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        UrlReader reader = new UrlReader() {
            @Override
            public BufferedReader read(String name) {
                return new BufferedReader(new StringReader("[{\n" +
                        "        \"title\": \"MoveOn - Free dance lessons\"," +
Severity: Major
Found in app/src/androidTest/java/ch/epfl/sweng/zuluzulu/fragments/AdminPanelFragmentAsAdminTest.java and 1 other location - About 1 hr to fix
app/src/androidTest/java/ch/epfl/sweng/zuluzulu/MementoFragmentTest.java on lines 30..51

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static EventDetailFragment newInstance(User user, Event event) {
        if (event == null)
            throw new IllegalArgumentException("Error creating an EventDetailFragment:\n" +
                    "Event is null");
        if (user == null)
Severity: Major
Found in app/src/main/java/ch/epfl/sweng/zuluzulu/fragments/EventDetailFragment.java and 1 other location - About 1 hr to fix
app/src/main/java/ch/epfl/sweng/zuluzulu/fragments/AssociationDetailFragment.java on lines 45..59

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 89.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static AssociationDetailFragment newInstance(User user, Association asso) {
        if (asso == null)
            throw new IllegalArgumentException("Error creating an AssociationDetailFragment:\n" +
                    "Association is null");
        if (user == null)
Severity: Major
Found in app/src/main/java/ch/epfl/sweng/zuluzulu/fragments/AssociationDetailFragment.java and 1 other location - About 1 hr to fix
app/src/main/java/ch/epfl/sweng/zuluzulu/fragments/EventDetailFragment.java on lines 46..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 89.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    @Test
    public void elementsArePresent() {
        onView(withId(R.id.main_fragment_followed_associations_text)).check(matches(isDisplayed()));
        onView(withId(R.id.main_fragment_followed_events_text)).check(matches(isDisplayed()));
        onView(withId(R.id.main_fragment_followed_associations_listview)).check(matches(isDisplayed()));
Severity: Major
Found in app/src/androidTest/java/ch/epfl/sweng/zuluzulu/fragments/MainFragmentAuthentUserTest.java and 1 other location - About 1 hr to fix
app/src/androidTest/java/ch/epfl/sweng/zuluzulu/fragments/MainFragmentGuestUserTest.java on lines 37..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    @Test
    public void elementsArePresent() {
        onView(withId(R.id.main_page_upcoming_events)).check(matches(isDisplayed()));
        onView(withId(R.id.main_page_list_event)).check(matches(isDisplayed()));
        onView(withId(R.id.main_page_random_assos)).check(matches(isDisplayed()));
Severity: Major
Found in app/src/androidTest/java/ch/epfl/sweng/zuluzulu/fragments/MainFragmentGuestUserTest.java and 1 other location - About 1 hr to fix
app/src/androidTest/java/ch/epfl/sweng/zuluzulu/fragments/MainFragmentAuthentUserTest.java on lines 27..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Override
    public void removeEventFromUserFollowedEvents(Event event, AuthenticatedUser user) {
        userCollection.document(user.getSciper()).update("followed_events", FieldValue.arrayRemove(event.getId()));
        userCollection.document(user.getSciper()).update("followed_channels", FieldValue.arrayRemove(event.getChannelId()));
        eventCollection.document(event.getId()).update("followers", FieldValue.arrayRemove(user.getSciper()));
Severity: Major
Found in app/src/main/java/ch/epfl/sweng/zuluzulu/firebase/FirebaseProxy.java and 1 other location - About 1 hr to fix
app/src/main/java/ch/epfl/sweng/zuluzulu/firebase/FirebaseProxy.java on lines 428..433

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Override
    public void addEventToUserFollowedEvents(Event event, AuthenticatedUser user) {
        userCollection.document(user.getSciper()).update("followed_events", FieldValue.arrayUnion(event.getId()));
        userCollection.document(user.getSciper()).update("followed_channels", FieldValue.arrayUnion(event.getChannelId()));
        eventCollection.document(event.getId()).update("followers", FieldValue.arrayUnion(user.getSciper()));
Severity: Major
Found in app/src/main/java/ch/epfl/sweng/zuluzulu/firebase/FirebaseProxy.java and 1 other location - About 1 hr to fix
app/src/main/java/ch/epfl/sweng/zuluzulu/firebase/FirebaseProxy.java on lines 461..466

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private void setUpReplyText() {
        replyText.addTextChangedListener(new TextWatcher() {
            @Override
            public void beforeTextChanged(CharSequence s, int start, int count, int after) {
            }
Severity: Minor
Found in app/src/main/java/ch/epfl/sweng/zuluzulu/fragments/ReplyFragment.java and 1 other location - About 50 mins to fix
app/src/main/java/ch/epfl/sweng/zuluzulu/fragments/ChatFragment.java on lines 116..132

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private void setUpEditText() {
        textEdit.addTextChangedListener(new TextWatcher() {
            @Override
            public void beforeTextChanged(CharSequence text, int start, int count, int after) {
            }
Severity: Minor
Found in app/src/main/java/ch/epfl/sweng/zuluzulu/fragments/ChatFragment.java and 1 other location - About 50 mins to fix
app/src/main/java/ch/epfl/sweng/zuluzulu/fragments/ReplyFragment.java on lines 107..123

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Override
    public void getEventsFromIds(List<String> ids, OnResult<List<Event>> onResult) {
        if (ids == null)
            return;
Severity: Minor
Found in app/src/androidTest/java/ch/epfl/sweng/zuluzulu/database/MockedProxy.java and 1 other location - About 50 mins to fix
app/src/androidTest/java/ch/epfl/sweng/zuluzulu/database/MockedProxy.java on lines 182..192

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Override
    public void getAssociationsFromIds(List<String> ids, OnResult<List<Association>> onResult) {
        if (ids == null)
            return;
Severity: Minor
Found in app/src/androidTest/java/ch/epfl/sweng/zuluzulu/database/MockedProxy.java and 1 other location - About 50 mins to fix
app/src/androidTest/java/ch/epfl/sweng/zuluzulu/database/MockedProxy.java on lines 170..180

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        channelCollection.document(id).collection("messages").getAndAddOnSuccessListener(fmapList -> {
            List<ChatMessage> result = new ArrayList<>();
            for (FirebaseMapDecorator fmap : fmapList) {
                if (fmap.hasFields(ChatMessage.requiredFields()))
                    result.add(new ChatMessage(fmap));
Severity: Minor
Found in app/src/main/java/ch/epfl/sweng/zuluzulu/firebase/FirebaseProxy.java and 1 other location - About 45 mins to fix
app/src/main/java/ch/epfl/sweng/zuluzulu/firebase/FirebaseProxy.java on lines 490..498

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    public static EventFragment newInstance(User user) {
        if(user == null)
            throw new IllegalArgumentException("user can't be null");
        EventFragment fragment = new EventFragment();
        Bundle args = new Bundle();
Severity: Major
Found in app/src/main/java/ch/epfl/sweng/zuluzulu/fragments/EventFragment.java and 4 other locations - About 45 mins to fix
app/src/main/java/ch/epfl/sweng/zuluzulu/fragments/AssociationFragment.java on lines 52..60
app/src/main/java/ch/epfl/sweng/zuluzulu/fragments/CalendarFragment.java on lines 54..62
app/src/main/java/ch/epfl/sweng/zuluzulu/fragments/ChannelFragment.java on lines 60..68
app/src/main/java/ch/epfl/sweng/zuluzulu/fragments/MainFragment.java on lines 60..68

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    public static MainFragment newInstance(User user) {
        if(user == null)
            throw new IllegalArgumentException("user can't be null");
        MainFragment fragment = new MainFragment();
        Bundle args = new Bundle();
Severity: Major
Found in app/src/main/java/ch/epfl/sweng/zuluzulu/fragments/MainFragment.java and 4 other locations - About 45 mins to fix
app/src/main/java/ch/epfl/sweng/zuluzulu/fragments/AssociationFragment.java on lines 52..60
app/src/main/java/ch/epfl/sweng/zuluzulu/fragments/CalendarFragment.java on lines 54..62
app/src/main/java/ch/epfl/sweng/zuluzulu/fragments/ChannelFragment.java on lines 60..68
app/src/main/java/ch/epfl/sweng/zuluzulu/fragments/EventFragment.java on lines 92..100

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                .collection("replies").getAndAddOnSuccessListener(fmapList -> {
            List<Post> result = new ArrayList<>();
            for (FirebaseMapDecorator data : fmapList) {
                if (data.hasFields(Post.requiredFields()))
                    result.add(new Post(data));
Severity: Minor
Found in app/src/main/java/ch/epfl/sweng/zuluzulu/firebase/FirebaseProxy.java and 1 other location - About 45 mins to fix
app/src/main/java/ch/epfl/sweng/zuluzulu/firebase/FirebaseProxy.java on lines 365..373

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language