Sign upLogin

nna774/OpenYo

View on GitHub
Star

Showing 3 of 7 total issues

Method tooFast has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def self.tooFast(database, fromUser)
    return true if RATE_BLACKBOX0(database, fromUser)
    delta = RATEDELTA
    max = RATEMAX
    span = RATESPAN
Severity: Minor
Found in yo.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method addImkayac has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def addImkayac(database, username, kayacId, kayacPass, kayacSec)
Severity: Minor
Found in yo.rb - About 35 mins to fix

    Method addImkayac has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def addImkayac(database, username, kayacId, kayacPass, kayacSec)
    return returnMsg 400, "need kayac_id." if kayacId.nil? || kayacId == ""
    database.query("INSERT INTO imkayac VALUES('#{username}', '#{database.escape(kayacId)}', #{if kayacPass.nil? then 'NULL' else "'#{database.escape(kayacPass)}'" end}, #{if kayacSec.nil? then 'NULL' else "'#{database.escape(kayacSec)}'" end})")
    exists = nil
    database.query("SELECT * FROM notifyType WHERE userId='#{database.escape(username)}' AND type='imkayac' LIMIT 1").each do |r|
    Severity: Minor
    Found in yo.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language