Sign upLogin

nning/moeil

View on GitHub
Star

Showing 4 of 4 total issues

Method permission? has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  def permission?(role, mailbox)
    # Deny if mailbox is nil.
    return false unless mailbox
    
    # Deny if mailbox is of wrong type.
Severity: Minor
Found in lib/permissionable.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_relocation has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  def create_relocation
    if persisted? and (username_changed? or domain_id_changed?)
      old_username = if username_changed?
        changes[:username].first
      else
Severity: Minor
Found in app/models/mailbox.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

      return true if perm.role == 'owner' and role == :editor
Severity: Major
Found in lib/permissionable.rb - About 30 mins to fix

    Method to_s has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def to_s
    if domain
      if username
        email
      else
    Severity: Minor
    Found in app/models/alias.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language