noobling/anglicare-sprint-week

View on GitHub
app_server/controllers/authentication.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function register has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports.register = (req, res, next) => {
  if (!req.body.fName
    || !req.body.lName
    || !req.body.email
    || !req.body.pwd
Severity: Major
Found in app_server/controllers/authentication.js - About 2 hrs to fix

    Consider simplifying this complex logical expression.
    Open

      if (!req.body.fName
        || !req.body.lName
        || !req.body.email
        || !req.body.pwd
        || !req.body.day
    Severity: Critical
    Found in app_server/controllers/authentication.js - About 1 hr to fix

      Function register has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      module.exports.register = (req, res, next) => {
        if (!req.body.fName
          || !req.body.lName
          || !req.body.email
          || !req.body.pwd
      Severity: Minor
      Found in app_server/controllers/authentication.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status