Sign upLogin

noobling/anglicare-sprint-week

View on GitHub
Star
app_server/controllers/locations.js

Summary

Maintainability
D
2 days
Test Coverage

Function showLocations has 99 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports.showLocations = (req, res) => {
  const name = req.body.fName + ' ' + req.body.lName;
  const longTerm = (req.params.lengthOfStay === 'long_term');
  const type = (longTerm ? ['transitional'] : ['crisis']);
  const age = parseInt(timeago().format(req.body.dob).split(' ')[0], 10);
Severity: Major
Found in app_server/controllers/locations.js - About 3 hrs to fix

    Function showLocation has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports.showLocation = (req, res) => {
  Service.findOne(
    { uri: req.params.serviceUri },
    'name description address amenities houseRules about img logo hours thankyouMessage stayLength',
  ).exec().then((service) => {
    Severity: Minor
    Found in app_server/controllers/locations.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                } else {
            unavailable.push(services[i]);
            // unavailable[unavailable.length - 1].available =
            //   services[i].isAvailable(services[i].beds);
            unavailableImagePromises.push(images.getImageForService(services[i].img[0]));
      Severity: Major
      Found in app_server/controllers/locations.js and 1 other location - About 2 hrs to fix
      app_server/controllers/locations.js on lines 66..72

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 82.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                if (services[i].isAvailable(services[i].beds)) {
            available.push(services[i]);
            // available[available.length - 1].available =
            //   services[i].isAvailable(services[i].beds);
            availableImagePromises.push(images.getImageForService(services[i].img[0]));
      Severity: Major
      Found in app_server/controllers/locations.js and 1 other location - About 2 hrs to fix
      app_server/controllers/locations.js on lines 72..78

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 82.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            logo.getImageForService(service.logo, req.params.serviceUri).then((result) => {
        res.render('showLocation', {
          location: service,
          images: results.images,
          logo: result,
      Severity: Major
      Found in app_server/controllers/locations.js and 1 other location - About 1 hr to fix
      app_server/controllers/locations.js on lines 143..169

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 73.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          images.getImagesForService(service, req.params.serviceUri).then((results) => {
      logo.getImageForService(service.logo, req.params.serviceUri).then((result) => {
        res.render('showLocation', {
          location: service,
          images: results.images,
      Severity: Major
      Found in app_server/controllers/locations.js and 1 other location - About 1 hr to fix
      app_server/controllers/locations.js on lines 144..159

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 73.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              Promise.all(unavailableImagePromises).then((unavailableImages) => {
          Promise.all(availableLogosPromises).then((availableLogos) => {
            Promise.all(unavailableLogosPromises).then((unavailableLogos) => {
              res.render('bedVacanciesList', {
                userName: name,
      Severity: Major
      Found in app_server/controllers/locations.js and 1 other location - About 1 hr to fix
      app_server/controllers/locations.js on lines 82..125

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            Promise.all(availableImagePromises).then((availableImages) => {
        Promise.all(unavailableImagePromises).then((unavailableImages) => {
          Promise.all(availableLogosPromises).then((availableLogos) => {
            Promise.all(unavailableLogosPromises).then((unavailableLogos) => {
              res.render('bedVacanciesList', {
      Severity: Major
      Found in app_server/controllers/locations.js and 1 other location - About 1 hr to fix
      app_server/controllers/locations.js on lines 83..113

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status