Sign upLogin

noobling/anglicare-sprint-week

View on GitHub
Star

Showing 64 of 226 total issues

Avoid too many return statements within this function.
Open

    return {
      label: 'SECURE',
      name: 'SECURE',
      icon: 'lock',
    };
Severity: Major
Found in app_server/controllers/service.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

          return {
        label: 'NO SMOKING',
        name: 'SMOKE',
        icon: 'smoke_free',
      };
    Severity: Major
    Found in app_server/controllers/service.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return {
      label: 'GYM',
      name: 'GYM',
      icon: 'fitness_center',
    };
      Severity: Major
      Found in app_server/controllers/service.js - About 30 mins to fix

        Function admin has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        module.exports.admin = (req, res) => {
  const prevPage = req.header('Referer') || '/';
  if (!req.user) {
    res.redirect(prevPage);
  } else if (req.user.role === 'admin') {
        Severity: Minor
        Found in app_server/controllers/admin.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language