noobling/anglicare-sprint-week

File validation.js has 327 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/**
 * Checks if the #addReview form has data for all 
 * fields if it doesn't then an error message is shown
 * to the user and the form does not submit to the server
 */

Consider simplifying this complex logical expression.

Open

    if (fname > 0 && lname > 0 && email > 0 && pass.length > 0 && con == pass && dob && gen > 0 && bool)
        $('#Reg').prop('disabled', false);
    else
        $('#Reg').prop('disabled', true);

Similar blocks of code found in 2 locations. Consider refactoring.

Open

$('#Rpwd').keyup( function() {
    const password = $(this).val();
    
    //TextBox left blank.
    if (password.length == 0) 

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

$('#pwd').keyup( function() {
    const pass = $(this).val();

    let regex = new Array();
    regex.push('[A-Z]'); //Uppercase Alphabet.

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

$('#phone').on('change keyup', function() {
    const phone = $(this).val();
    const numReg = /^[0-9]+$/;

    if(numReg.test(phone) && phone.length == 10)

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

$('#fName').on('change keyup', function() {
    let first = $(this).val();
    const nameReg = /^\b(?![\s]+$)[a-zA-Z'\s-]+\b$/;    

    validate(false);

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

$('#lName').on('change keyup', function() {
    let last = $(this).val();
    const nameReg = /^\b(?![\s]+$)[a-zA-Z'\s-]+\b$/;

    validate(false);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

$('#Cpwd').keyup( function() {
    let confirm = $(this).val();
    let pass = $('#Rpwd').val();

    validate(false);

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

$('#email').on('change keyup', function() {
    const email = $(this).val();
    const emailReg = /^[a-zA-Z0-9.!#$%&’*+/=?^_`{|}~-]+@[a-zA-Z0-9-]+(?:\.[a-zA-Z0-9-]+)*$/

    validate(false);

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

$('#Lemail').on('change keyup', function() {
    const email = $(this).val();
    const emailReg = /^[a-zA-Z0-9.!#$%&’*+/=?^_`{|}~-]+@[a-zA-Z0-9-]+(?:\.[a-zA-Z0-9-]+)*$/

    validLogin(false);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

function validate(bool)
{
    const fname = $('#fName').val().length;
    const lname = $('#lName').val().length;
    const gen = $('#gender').val().length;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

function dateValid()
{
    const dd = $('#day').val();
    const mm = Number($('#month').val())+1;
    const yy = $('#year').val();

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

function dateReg()
{
    var datReg = /^(?=\d)(?:(?:31(?!.(?:0?[2469]|11))|(?:30|29)(?!.0?2)|29(?=.0?2.(?:(?:(?:1[6-9]|[2-9]\d)?(?:0[48]|[2468][048]|[13579][26])|(?:(?:16|[2468][048]|[3579][26])00)))(?:\x20|$))|(?:2[0-8]|1\d|0?[1-9]))([-.\/])(?:1[012]|0?[1-9])\1(?:1[6-9]|[2-9]\d)?\d\d(?:(?=\x20\d)\x20|$))?(((0?[1-9]|1[012])(:[0-5]\d){0,2}(\x20[AP]M))|([01]\d|2[0-3])(:[0-5]\d){1,2})?$/;

    const dd = $('#day').val();

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

function validLogin(bool)
{
        const email = $('#Lemail').val().length;
        const pass = $('#pwd').val().length;

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    if (!$('input#name').val() || !$('select#rating').val() || !$('textarea#review').val()) {
        if ($('.alert.alert-danger').length) {
            $('.alert.alert-danger').show();
        } else {
            $(this).prepend("<div role='alert' class='alert alert-danger'>All fields required, please try again</div>");

• Read up
  Read up