Sign upLogin

noodlefrenzy/node-amqp10

View on GitHub
Star
lib/session.js

Summary

Maintainability
C
1 day
Test Coverage

File session.js has 382 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

var EventEmitter = require('events').EventEmitter,
    util = require('util'),
Severity: Minor
Found in lib/session.js - About 5 hrs to fix

    Function stateMachine has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var stateMachine = function(session) {
  function warnBeginState(state) {
    console.warn('BUG: Tried to call begin() on a session in nonterminal state ' + state);
  }
    Severity: Minor
    Found in lib/session.js - About 1 hr to fix

      Function _processFrame has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      Session.prototype._processFrame = function(frame) {
  if (frame instanceof frames.BeginFrame && (frame.remoteChannel === this.channel)) {
    this.sm.beginReceived();
    this._beginReceived(frame);
    return;
      Severity: Minor
      Found in lib/session.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function createLink has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Session.prototype.createLink = function(linkPolicy) {
  var policy = u.deepCopy(linkPolicy),
      attachOptions = policy.attach || {};

  attachOptions.handle = this._nextHandle();
      Severity: Minor
      Found in lib/session.js - About 1 hr to fix

        Avoid too many return statements within this function.
        Open

          else if (frame instanceof frames.DispositionFrame) return this._processDispositionFrame(frame);
        Severity: Major
        Found in lib/session.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

            else if (frame instanceof frames.AttachFrame) return this._processAttachFrame(frame);
          Severity: Major
          Found in lib/session.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

              else if (frame instanceof frames.DetachFrame) return this._processDetachFrame(frame);
            Severity: Major
            Found in lib/session.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                else if (frame instanceof frames.FlowFrame) return this._processFlowFrame(frame);
              Severity: Major
              Found in lib/session.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                  else if (frame instanceof frames.TransferFrame) return this._processTransferFrame(frame);
                Severity: Major
                Found in lib/session.js - About 30 mins to fix

                  Function end has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  Session.prototype.end = function(options) {
  options = options || { dispose: false };

  if (options.dispose) this._disposed = true;
  if (this._reestablishTimer) clearTimeout(this._reestablishTimer);
                  Severity: Minor
                  Found in lib/session.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    this.sm.bind(function(event, oldState, newState) {
    debug('stateChange(' + self.remoteChannel + '):', oldState, '=>', newState, ', reason:', event);
  });
                  Severity: Minor
                  Found in lib/session.js and 1 other location - About 35 mins to fix
                  lib/link.js on lines 73..75

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 47.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status