Sign upLogin

notduncansmith/summit

View on GitHub
Star
cms/page.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function exports has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function (app) {
  return app.collection({
    name: 'Page',
    isPostType: true,
    timestamps: true,
Severity: Minor
Found in cms/page.js - About 1 hr to fix

    Function exports has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = function (app) {
  return app.collection({
    name: 'Page',
    isPostType: true,
    timestamps: true,
    Severity: Minor
    Found in cms/page.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        fields: {
      title: 'string',
      body: 'text',
      get slug() {
        return slugify(this.title);
    Severity: Major
    Found in cms/page.js and 1 other location - About 1 hr to fix
    cms/post.js on lines 9..18

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

            bySlug: {
          map: function (doc) {
            if (doc.type === 'Page' && doc.slug) {
              emit(doc.slug, doc);
            }
    Severity: Major
    Found in cms/page.js and 9 other locations - About 50 mins to fix
    cms/page.js on lines 30..36
    cms/post.js on lines 22..28
    cms/post.js on lines 29..35
    cms/post.js on lines 36..42
    lib/collection/group.js on lines 96..102
    lib/collection/user.js on lines 239..245
    lib/collection/user.js on lines 247..253
    lib/collection/user.js on lines 255..261
    lib/services/mailer.js on lines 16..22

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

            by_slug: {
          map: function (doc) {
            if (doc.type == 'Page' && doc.slug) {
              emit(doc.slug, doc);
            }
    Severity: Major
    Found in cms/page.js and 9 other locations - About 50 mins to fix
    cms/page.js on lines 23..29
    cms/post.js on lines 22..28
    cms/post.js on lines 29..35
    cms/post.js on lines 36..42
    lib/collection/group.js on lines 96..102
    lib/collection/user.js on lines 239..245
    lib/collection/user.js on lines 247..253
    lib/collection/user.js on lines 255..261
    lib/services/mailer.js on lines 16..22

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status