Sign upLogin

notifme/notifme-sdk

View on GitHub
Star
lib/providers/slack/notificationCatcher.js

Summary

Maintainability
C
1 day
Test Coverage

Function value has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    value: function () {
      var _send = (0, _asyncToGenerator2["default"])( /*#__PURE__*/_regenerator["default"].mark(function _callee(request) {
        var _ref, text;
        return _regenerator["default"].wrap(function _callee$(_context) {
          while (1) switch (_context.prev = _context.next) {
Severity: Minor
Found in lib/providers/slack/notificationCatcher.js - About 1 hr to fix

    Function _callee has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          var _send = (0, _asyncToGenerator2["default"])( /*#__PURE__*/_regenerator["default"].mark(function _callee(request) {
        var _ref, text;
        return _regenerator["default"].wrap(function _callee$(_context) {
          while (1) switch (_context.prev = _context.next) {
            case 0:
    Severity: Minor
    Found in lib/providers/slack/notificationCatcher.js - About 1 hr to fix

      Function _callee$ has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              return _regenerator["default"].wrap(function _callee$(_context) {
          while (1) switch (_context.prev = _context.next) {
            case 0:
              if (!request.customize) {
                _context.next = 6;
      Severity: Minor
      Found in lib/providers/slack/notificationCatcher.js - About 1 hr to fix

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

        function _callSuper(t, o, e) { return o = (0, _getPrototypeOf2["default"])(o), (0, _possibleConstructorReturn2["default"])(t, _isNativeReflectConstruct() ? _Reflect$construct(o, e || [], (0, _getPrototypeOf2["default"])(t).constructor) : o.apply(t, e)); }
        Severity: Major
        Found in lib/providers/slack/notificationCatcher.js and 5 other locations - About 2 hrs to fix
        lib/providers/email/notificationCatcher.js on lines 18..18
        lib/providers/push/notificationCatcher.js on lines 29..29
        lib/providers/sms/notificationCatcher.js on lines 18..18
        lib/providers/voice/notificationCatcher.js on lines 18..18
        lib/providers/webpush/notificationCatcher.js on lines 29..29

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 88.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

        function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.call(_Reflect$construct(Boolean, [], function () {})); } catch (t) {} return (_isNativeReflectConstruct = function _isNativeReflectConstruct() { return !!t; })(); }
        Severity: Major
        Found in lib/providers/slack/notificationCatcher.js and 5 other locations - About 2 hrs to fix
        lib/providers/email/notificationCatcher.js on lines 19..19
        lib/providers/push/notificationCatcher.js on lines 30..30
        lib/providers/sms/notificationCatcher.js on lines 19..19
        lib/providers/voice/notificationCatcher.js on lines 19..19
        lib/providers/webpush/notificationCatcher.js on lines 30..30

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 85.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status