nshimiye/relay

View on GitHub
src/slackRelay/SlackRelay.js

Summary

Maintainability
D
2 days
Test Coverage

File SlackRelay.js has 255 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

/**
 * Stand for a bot user
 * in charge of carrying messages from a locally confugured bot to slack
Severity: Minor
Found in src/slackRelay/SlackRelay.js - About 2 hrs to fix

    Function connect has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      connect() {
        let connectionTimeout;
        let _rtm = rtm.get(this);
        let token = token_private.get(this);
        let slackRelayInstance = this;
    Severity: Minor
    Found in src/slackRelay/SlackRelay.js - About 1 hr to fix

      Function promisedResponse has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          let promisedResponse = new Promise(function(resolve, reject) {
            // @DONE make sure bot is not already connected
            // if so then just return this instance
            if (_rtm.connected) {
              resolve(slackRelayInstance);
      Severity: Minor
      Found in src/slackRelay/SlackRelay.js - About 1 hr to fix

        Function _intializeSlackListener has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          _intializeSlackListener() {
            let _rtm = rtm.get(this);
        
            let self = this;
            _rtm.on(RTM_EVENTS.MESSAGE, function handleRtmMessage(message) {
        Severity: Minor
        Found in src/slackRelay/SlackRelay.js - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                this._genericSend(text, data, channelid).then(success_object => {
                  resolve(success_object);
                }, error_object => {
                  reject(error_object);
                }).catch(e => {
          Severity: Major
          Found in src/slackRelay/SlackRelay.js and 1 other location - About 3 hrs to fix
          src/slackRelay/SlackRelay.js on lines 173..182

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 102.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                this._genericSend(text, data, channelid).then(success_object => {
                  resolve(success_object);
                }, error_object => {
                  reject(error_object);
                }).catch(e => {
          Severity: Major
          Found in src/slackRelay/SlackRelay.js and 1 other location - About 3 hrs to fix
          src/slackRelay/SlackRelay.js on lines 212..221

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 102.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              all_users.forEach(user => { let cid = ( ims_clean.filter(channel => { return channel.userid === user.userid; })[0] || {} ).channelid; user.channelid = cid; });
          Severity: Major
          Found in src/slackRelay/SlackRelay.js and 1 other location - About 2 hrs to fix
          src/botkitRelay/BotkitRelay.js on lines 131..131

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 76.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            disconnect() {
              let _rtm = rtm.get(this);
              console.log('== disconnect ==', _rtm.slackAPIUrl, _rtm.userAgent, _rtm._token, _rtm.token);
              _rtm.disconnect();
            }
          Severity: Major
          Found in src/slackRelay/SlackRelay.js and 1 other location - About 1 hr to fix
          src/botkitRelay/BotkitRelay.js on lines 164..168

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status