Sign upLogin

nus-mtp/cs-modify

View on GitHub
Star
static/javascripts/individualModuleInfo.js

Summary

Maintainability
F
5 days
Test Coverage

Function onload has 123 lines of code (exceeds 25 allowed). Consider refactoring.
Open

window.onload = function () {
    studentYearBarChart = new CanvasJS.Chart("module-view-student-year-bar-chart",
    {
        animationEnabled: true,
        axisY: {
Severity: Major
Found in static/javascripts/individualModuleInfo.js - About 4 hrs to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        focusAreaBarChart = new CanvasJS.Chart("module-view-focus-area-bar-chart",
    {
        animationEnabled: true,
        axisY: {
            title: "Number of Students",
    Severity: Major
    Found in static/javascripts/individualModuleInfo.js and 3 other locations - About 3 hrs to fix
    static/javascripts/individualModuleInfo.js on lines 2..26
    static/javascripts/studentEnrollment.js on lines 2..26
    static/javascripts/studentEnrollment.js on lines 54..78

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 113.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        studentYearBarChart = new CanvasJS.Chart("module-view-student-year-bar-chart",
    {
        animationEnabled: true,
        axisY: {
            title: "Number of Students",
    Severity: Major
    Found in static/javascripts/individualModuleInfo.js and 3 other locations - About 3 hrs to fix
    static/javascripts/individualModuleInfo.js on lines 54..78
    static/javascripts/studentEnrollment.js on lines 2..26
    static/javascripts/studentEnrollment.js on lines 54..78

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 113.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    function showFocusAreaPieChart() {
    document.getElementById('module-view-focus-area-pie-chart').style.display = "block";
    document.getElementById('module-view-focus-area-bar-chart').style.display = "none";
    document.getElementById('module-view-focus-area-pie-chart-button').classList.add("active");
    document.getElementById('module-view-focus-area-bar-chart-button').classList.remove("active");
    Severity: Major
    Found in static/javascripts/individualModuleInfo.js and 7 other locations - About 3 hrs to fix
    static/javascripts/individualModuleInfo.js on lines 146..152
    static/javascripts/individualModuleInfo.js on lines 154..160
    static/javascripts/individualModuleInfo.js on lines 162..168
    static/javascripts/studentEnrollment.js on lines 107..113
    static/javascripts/studentEnrollment.js on lines 115..121
    static/javascripts/studentEnrollment.js on lines 123..129
    static/javascripts/studentEnrollment.js on lines 131..137

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 110.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    function showStudentYearPieChart() {
    document.getElementById('module-view-student-year-pie-chart').style.display = "block";
    document.getElementById('module-view-student-year-bar-chart').style.display = "none";
    document.getElementById('module-view-student-year-pie-chart-button').classList.add("active");
    document.getElementById('module-view-student-year-bar-chart-button').classList.remove("active");
    Severity: Major
    Found in static/javascripts/individualModuleInfo.js and 7 other locations - About 3 hrs to fix
    static/javascripts/individualModuleInfo.js on lines 146..152
    static/javascripts/individualModuleInfo.js on lines 162..168
    static/javascripts/individualModuleInfo.js on lines 170..176
    static/javascripts/studentEnrollment.js on lines 107..113
    static/javascripts/studentEnrollment.js on lines 115..121
    static/javascripts/studentEnrollment.js on lines 123..129
    static/javascripts/studentEnrollment.js on lines 131..137

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 110.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    function showStudentYearBarChart() {
    document.getElementById('module-view-student-year-bar-chart').style.display = "block";
    document.getElementById('module-view-student-year-pie-chart').style.display = "none";
    document.getElementById('module-view-student-year-bar-chart-button').classList.add("active");
    document.getElementById('module-view-student-year-pie-chart-button').classList.remove("active");
    Severity: Major
    Found in static/javascripts/individualModuleInfo.js and 7 other locations - About 3 hrs to fix
    static/javascripts/individualModuleInfo.js on lines 154..160
    static/javascripts/individualModuleInfo.js on lines 162..168
    static/javascripts/individualModuleInfo.js on lines 170..176
    static/javascripts/studentEnrollment.js on lines 107..113
    static/javascripts/studentEnrollment.js on lines 115..121
    static/javascripts/studentEnrollment.js on lines 123..129
    static/javascripts/studentEnrollment.js on lines 131..137

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 110.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    function showFocusAreaBarChart() {
    document.getElementById('module-view-focus-area-bar-chart').style.display = "block";
    document.getElementById('module-view-focus-area-pie-chart').style.display = "none";
    document.getElementById('module-view-focus-area-bar-chart-button').classList.add("active");
    document.getElementById('module-view-focus-area-pie-chart-button').classList.remove("active");
    Severity: Major
    Found in static/javascripts/individualModuleInfo.js and 7 other locations - About 3 hrs to fix
    static/javascripts/individualModuleInfo.js on lines 146..152
    static/javascripts/individualModuleInfo.js on lines 154..160
    static/javascripts/individualModuleInfo.js on lines 170..176
    static/javascripts/studentEnrollment.js on lines 107..113
    static/javascripts/studentEnrollment.js on lines 115..121
    static/javascripts/studentEnrollment.js on lines 123..129
    static/javascripts/studentEnrollment.js on lines 131..137

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 110.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        studentYearPieChart = new CanvasJS.Chart("module-view-student-year-pie-chart",
    {
        animationEnabled: true,
        legend: {
            verticalAlign: "center",
    Severity: Major
    Found in static/javascripts/individualModuleInfo.js and 2 other locations - About 3 hrs to fix
    static/javascripts/studentEnrollment.js on lines 30..52
    static/javascripts/studentEnrollment.js on lines 82..104

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 106.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        edit_specific_info_btn.onclick = function() {
      modal.style.display = "block";
      document.getElementById("edit-specific-info-modal").style.display = "block";
      document.getElementById("overlapping-mods-modal").style.display = "none";
      document.getElementById("students-taking-modal").style.display = "none";
    Severity: Major
    Found in static/javascripts/individualModuleInfo.js and 1 other location - About 3 hrs to fix
    static/javascripts/viewModule.js on lines 104..109

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 102.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        students_taking_btn.onclick = function() {
      modal.style.display = "block";
      document.getElementById("edit-specific-info-modal").style.display = "none";
      document.getElementById("overlapping-mods-modal").style.display = "none";
      document.getElementById("students-taking-modal").style.display = "block";
    Severity: Major
    Found in static/javascripts/individualModuleInfo.js and 1 other location - About 3 hrs to fix
    static/javascripts/viewModule.js on lines 116..121

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 102.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        overlapping_mods_btn.onclick = function() {
      modal.style.display = "block";
      document.getElementById("edit-specific-info-modal").style.display = "none";
      document.getElementById("overlapping-mods-modal").style.display = "block";
      document.getElementById("students-taking-modal").style.display = "none";
    Severity: Major
    Found in static/javascripts/individualModuleInfo.js and 1 other location - About 3 hrs to fix
    static/javascripts/viewModule.js on lines 110..115

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 100.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

        window.onclick = function(event) {
      if (event.target == modal) {
          modal.style.display = "none";
      }
    }
    Severity: Major
    Found in static/javascripts/individualModuleInfo.js and 2 other locations - About 40 mins to fix
    static/javascripts/modulesTakenPriorToOthers.js on lines 40..44
    static/javascripts/viewModule.js on lines 124..128

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status