Sign upLogin

nus-mtp/sashimi-note

View on GitHub
Star
sashimi-webapp/src/database/data-modifier/dataAdd.js

Summary

Maintainability
A
4 hrs
Test Coverage

Function createNewFile has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function createNewFile(organizationId, filePath, folderId, newFileId, newFileName) {
  return new Promise((resolve, reject) => {
    const currentDateTime = dateTime.getCurrentLongTime();

    const fileOrganizationId = organizationId;
Severity: Minor
Found in sashimi-webapp/src/database/data-modifier/dataAdd.js - About 1 hr to fix

    Function createNewFile has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function createNewFile(organizationId, filePath, folderId, newFileId, newFileName) {
    Severity: Minor
    Found in sashimi-webapp/src/database/data-modifier/dataAdd.js - About 35 mins to fix

      Function createNewFolder has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      function createNewFolder(organizationId, folderPath, currentFolderId, newFolderId, newFolderName) {
      Severity: Minor
      Found in sashimi-webapp/src/database/data-modifier/dataAdd.js - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            return sqlCommands.insertContent(constants.ENTITIES_FOLDER, newFolderData)
    .then(success => resolve(newFolderData[0]))
    .catch(err => reject(err));
        Severity: Minor
        Found in sashimi-webapp/src/database/data-modifier/dataAdd.js and 1 other location - About 50 mins to fix
        sashimi-webapp/src/database/data-modifier/dataAdd.js on lines 38..40

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            return sqlCommands.insertContent(constants.ENTITIES_FILE_MANAGER, newFileData)
    .then(success => resolve(newFileData[0]))
    .catch(sqlErr => reject(sqlErr));
        Severity: Minor
        Found in sashimi-webapp/src/database/data-modifier/dataAdd.js and 1 other location - About 50 mins to fix
        sashimi-webapp/src/database/data-modifier/dataAdd.js on lines 68..70

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status