nus-mtp/sashimi-note

View on GitHub
sashimi-webapp/src/helpers/elementUtils.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function scrollTo has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  scrollTo(destination, duration = 200, callback) {
    // Handle case where this code is used in an iframe element
    let viewerDoc = this.getDocument(destination);
    let viewWindow = this.getWindow(destination);
    if (typeof destination === 'number') {
Severity: Minor
Found in sashimi-webapp/src/helpers/elementUtils.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function scrollTo has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  scrollTo(destination, duration = 200, callback) {
    // Handle case where this code is used in an iframe element
    let viewerDoc = this.getDocument(destination);
    let viewWindow = this.getWindow(destination);
    if (typeof destination === 'number') {
Severity: Minor
Found in sashimi-webapp/src/helpers/elementUtils.js - About 1 hr to fix

    Function resolveElement has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      resolveElement(targetReference, altDocument) {
        if (typeof targetReference === 'string') {
          const doc = altDocument || document;
          return doc.getElementById(targetReference);
        } else if (targetReference.window === targetReference) {
    Severity: Minor
    Found in sashimi-webapp/src/helpers/elementUtils.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status