Sign upLogin

nus-mtp/sashimi-note

View on GitHub
Star
sashimi-webapp/src/logic/filemanager/data/folder.js

Summary

Maintainability
C
1 day
Test Coverage

Function rename has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

Folder.prototype.rename = function rename(newFolderName) {
  if (!(this instanceof Folder)) {
    throw new Error(ERROR_NOT_FOLDER_INSTANCE);
  }
Severity: Minor
Found in sashimi-webapp/src/logic/filemanager/data/folder.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    return new Promise((resolve, reject) => reject(ERROR_SAME_FOLDER_NAME));
Severity: Major
Found in sashimi-webapp/src/logic/filemanager/data/folder.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return storage.renameFolder(this.id, newFolderName)
    .then(() => {
      const oldFolderName = this.name;
      this.name = newFolderName;
      this.path = this.path.replace(oldFolderName, newFolderName);
    Severity: Major
    Found in sashimi-webapp/src/logic/filemanager/data/folder.js - About 30 mins to fix

      Function hasSameFolderName has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      function hasSameFolderName(newFolderName) {
  if (!(this instanceof Folder)) {
    throw new Error(ERROR_NOT_FOLDER_INSTANCE);
  }
  const currParentFolder = this.parentFolder;
      Severity: Minor
      Found in sashimi-webapp/src/logic/filemanager/data/folder.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      function hasSameFolderName(newFolderName) {
  if (!(this instanceof Folder)) {
    throw new Error(ERROR_NOT_FOLDER_INSTANCE);
  }
  const currParentFolder = this.parentFolder;
      Severity: Major
      Found in sashimi-webapp/src/logic/filemanager/data/folder.js and 1 other location - About 5 hrs to fix
      sashimi-webapp/src/logic/filemanager/data/file.js on lines 62..81

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 141.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        return storage.deleteFolder(this.id)
  .then(() => {
    idMap.removeFolderFromMap(this.id);
    const parentFolder = this.parentFolder;
    const index = parentFolder.childFolderList.indexOf(this);
      Severity: Major
      Found in sashimi-webapp/src/logic/filemanager/data/folder.js and 1 other location - About 2 hrs to fix
      sashimi-webapp/src/logic/filemanager/data/file.js on lines 89..95

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 87.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        } else if (hasSameFolderName.call(this, newFolderName)) {
    return new Promise((resolve, reject) => reject(ERROR_SAME_FOLDER_NAME));
  } else {
    return storage.renameFolder(this.id, newFolderName)
    .then(() => {
      Severity: Major
      Found in sashimi-webapp/src/logic/filemanager/data/folder.js and 1 other location - About 2 hrs to fix
      sashimi-webapp/src/logic/filemanager/data/file.js on lines 180..189

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 79.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status