Sign upLogin

nus-mtp/sashimi-note

View on GitHub
Star
sashimi-webapp/test/e2e/specs/pageRenderer/page-break.spec.js

Summary

Maintainability
D
1 day
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('should render dangling oversized content to the next page', (browser) => {
      pagesModeActivation(browser);
      codeMirrorTextInsert(browser, textLoader.load('references/oversized-content-at-middle'));

      // The loaded document will attempt to fill up page 1 with multiple oneline paragraphs,
Severity: Major
Found in sashimi-webapp/test/e2e/specs/pageRenderer/page-break.spec.js and 1 other location - About 4 hrs to fix
sashimi-webapp/test/e2e/specs/pageRenderer/page-break.spec.js on lines 86..104

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('should render oversized content that begins on a new page to the same page', (browser) => {
      pagesModeActivation(browser);
      codeMirrorTextInsert(browser, textLoader.load('references/oversized-content-at-beginning'));

      // Similar to the test above,
Severity: Major
Found in sashimi-webapp/test/e2e/specs/pageRenderer/page-break.spec.js and 1 other location - About 4 hrs to fix
sashimi-webapp/test/e2e/specs/pageRenderer/page-break.spec.js on lines 66..84

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('should apply page break to headings located at the bottom of the page', (browser) => {
      pagesModeActivation(browser);
      codeMirrorTextInsert(browser, textLoader.load('references/pagebreak-on-headers-at-bottom'));

      // The loaded document is purposelly filled until 17.9% before inserting
Severity: Major
Found in sashimi-webapp/test/e2e/specs/pageRenderer/page-break.spec.js and 1 other location - About 2 hrs to fix
sashimi-webapp/test/e2e/specs/pageRenderer/page-break.spec.js on lines 36..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 84.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('should apply page break to H1 element', (browser) => {
      pagesModeActivation(browser);
      codeMirrorTextInsert(browser, textLoader.load('references/pagebreak-before-h1-elements'));

      // The loaded document will attempt to insert 3 H1 elements into the document
Severity: Major
Found in sashimi-webapp/test/e2e/specs/pageRenderer/page-break.spec.js and 1 other location - About 2 hrs to fix
sashimi-webapp/test/e2e/specs/pageRenderer/page-break.spec.js on lines 7..19

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 84.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status