Sign upLogin

nus-mtp/sashimi-note

View on GitHub
Star
sashimi-webapp/test/unit/specs/database/data-modifier/dataAdd.spec.js

Summary

Maintainability
C
1 day
Test Coverage

Identical blocks of code found in 5 locations. Consider refactoring.
Open

function deleteDatabase(databaseName) {
  return new Promise((resolve, reject) => {
    const thisDatabaseName = databaseName || testDatabaseName;
    if (!window.indexedDB) {
      reject(exceptions.IndexedDBNotSupported);
Severity: Major
Found in sashimi-webapp/test/unit/specs/database/data-modifier/dataAdd.spec.js and 4 other locations - About 2 hrs to fix
sashimi-webapp/test/unit/specs/database/create/entitiesCreator.spec.js on lines 45..53
sashimi-webapp/test/unit/specs/database/create/tableCreator.spec.js on lines 23..31
sashimi-webapp/test/unit/specs/database/retrieve/query.spec.js on lines 10..18
sashimi-webapp/test/unit/specs/database/sql-related/sqlCommands.spec.js on lines 44..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 77.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      dataAdd.createNewFolder(1, '/root/', 0)
      .then(() =>
        sqlCommands.getMaxFolderId()
        .then(maxFileId =>
          expect(maxFileId).to.equal(1)
Severity: Major
Found in sashimi-webapp/test/unit/specs/database/data-modifier/dataAdd.spec.js and 1 other location - About 1 hr to fix
sashimi-webapp/test/unit/specs/database/data-modifier/dataAdd.spec.js on lines 125..140

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      dataAdd.createNewFile(1, '/root/', 0)
      .then(() =>
        sqlCommands.getMaxFileId()
        .then(maxFileId =>
          expect(maxFileId).to.equal(2)
Severity: Major
Found in sashimi-webapp/test/unit/specs/database/data-modifier/dataAdd.spec.js and 1 other location - About 1 hr to fix
sashimi-webapp/test/unit/specs/database/data-modifier/dataAdd.spec.js on lines 148..163

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  const thirdFile = [{
    organization_id: 1,
    folder_id: 0,
    file_id: 3,
    file_name: 'copy of abcd',
Severity: Major
Found in sashimi-webapp/test/unit/specs/database/data-modifier/dataAdd.spec.js and 9 other locations - About 1 hr to fix
sashimi-webapp/test/unit/specs/database/data-modifier/dataAdd.spec.js on lines 27..37
sashimi-webapp/test/unit/specs/database/retrieve/query.spec.js on lines 27..37
sashimi-webapp/test/unit/specs/database/sql-related/sqlCommands.spec.js on lines 151..161
sashimi-webapp/test/unit/specs/database/sql-related/sqlCommands.spec.js on lines 162..172
sashimi-webapp/test/unit/specs/database/sql-related/sqlCommands.spec.js on lines 173..183
sashimi-webapp/test/unit/specs/database/sql-related/sqlCommands.spec.js on lines 184..194
sashimi-webapp/test/unit/specs/database/sql-related/sqlCommands.spec.js on lines 195..205
sashimi-webapp/test/unit/specs/database/sql-related/sqlCommands.spec.js on lines 206..216
sashimi-webapp/test/unit/specs/database/sql-related/sqlCommands.spec.js on lines 217..227

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  const secondFile = [{
    organization_id: 1,
    folder_id: 0,
    file_id: 2,
    file_name: 'newFile',
Severity: Major
Found in sashimi-webapp/test/unit/specs/database/data-modifier/dataAdd.spec.js and 1 other location - About 1 hr to fix
sashimi-webapp/test/unit/specs/database/retrieve/query.spec.js on lines 38..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  const firstFile = [{
    organization_id: 1,
    folder_id: 0,
    file_id: 1,
    file_name: 'abcd',
Severity: Major
Found in sashimi-webapp/test/unit/specs/database/data-modifier/dataAdd.spec.js and 9 other locations - About 1 hr to fix
sashimi-webapp/test/unit/specs/database/data-modifier/dataAdd.spec.js on lines 49..59
sashimi-webapp/test/unit/specs/database/retrieve/query.spec.js on lines 27..37
sashimi-webapp/test/unit/specs/database/sql-related/sqlCommands.spec.js on lines 151..161
sashimi-webapp/test/unit/specs/database/sql-related/sqlCommands.spec.js on lines 162..172
sashimi-webapp/test/unit/specs/database/sql-related/sqlCommands.spec.js on lines 173..183
sashimi-webapp/test/unit/specs/database/sql-related/sqlCommands.spec.js on lines 184..194
sashimi-webapp/test/unit/specs/database/sql-related/sqlCommands.spec.js on lines 195..205
sashimi-webapp/test/unit/specs/database/sql-related/sqlCommands.spec.js on lines 206..216
sashimi-webapp/test/unit/specs/database/sql-related/sqlCommands.spec.js on lines 217..227

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  const rootFolder = [{
    folder_id: 0,
    parent_folder_id: -1,
    organization_id: 1,
    creation_date: 4433,
Severity: Minor
Found in sashimi-webapp/test/unit/specs/database/data-modifier/dataAdd.spec.js and 1 other location - About 35 mins to fix
sashimi-webapp/test/unit/specs/database/retrieve/query.spec.js on lines 49..57

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  const firstFolder = [{
    folder_id: 1,
    parent_folder_id: 0,
    organization_id: 1,
    creation_date: 4433,
Severity: Minor
Found in sashimi-webapp/test/unit/specs/database/data-modifier/dataAdd.spec.js and 1 other location - About 30 mins to fix
sashimi-webapp/test/unit/specs/database/retrieve/query.spec.js on lines 58..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status