Sign upLogin

oaeproject/Hilary

View on GitHub
Star
packages/oae-activity/lib/api.js

Summary

Maintainability
B
5 hrs
Test Coverage
A
97%

Function getActivityStream has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

const getActivityStream = function (ctx, principalId, start, limit, transformerType, callback) {
Severity: Minor
Found in packages/oae-activity/lib/api.js - About 45 mins to fix

    Function getNotificationStream has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    const getNotificationStream = function (ctx, userId, start, limit, transformerType, callback) {
    Severity: Minor
    Found in packages/oae-activity/lib/api.js - About 45 mins to fix

      Function _getActivityStream has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      const _getActivityStream = function (ctx, activityStreamId, start, limit, transformerType, callback) {
      Severity: Minor
      Found in packages/oae-activity/lib/api.js - About 45 mins to fix

        Function refreshConfiguration has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        const refreshConfiguration = function (config, callback) {
  callback =
    callback ||
    function (error) {
      if (error) {
        Severity: Minor
        Found in packages/oae-activity/lib/api.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        export {
  removeActivityStream,
  refreshConfiguration,
  registerActivityStreamType,
  getRegisteredActivityStreamType,
        Severity: Major
        Found in packages/oae-activity/lib/api.js and 1 other location - About 1 hr to fix
        packages/oae-preview-processor/lib/api.js on lines 777..790

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Invalid

        const {
  getNestedObject,
  validateInCase: bothCheck,
  unless,
  isLoggedInUser,
        Severity: Major
        Found in packages/oae-activity/lib/api.js and 5 other locations - About 55 mins to fix
        packages/oae-folders/lib/internal/dao.js on lines 359..360
        packages/oae-jitsi/lib/internal/dao.js on lines 199..200
        packages/oae-jitsi/lib/internal/dao.js on lines 228..228
        packages/oae-jitsi/lib/model.js on lines 21..21
        packages/oae-folders/lib/model.js on lines 41..41

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          callback =
    callback ||
    function (error) {
      if (error) {
        log().error({ err: error, activitySeed }, 'Error posting activity');
        Severity: Minor
        Found in packages/oae-activity/lib/api.js and 1 other location - About 50 mins to fix
        packages/oae-principals/lib/api.user.js on lines 177..189

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 7 locations. Consider refactoring.
        Open

          callback =
    callback ||
    function (error) {
      if (error) {
        log().error({ err: error }, 'Error refreshing activities configuration');
        Severity: Major
        Found in packages/oae-activity/lib/api.js and 6 other locations - About 30 mins to fix
        packages/oae-activity/lib/internal/buckets.js on lines 90..96
        packages/oae-activity/lib/internal/dao.js on lines 143..149
        packages/oae-activity/lib/internal/email.js on lines 199..205
        packages/oae-principals/lib/internal/dao.js on lines 793..799
        packages/oae-preview-processor/lib/api.js on lines 347..353
        packages/oae-preview-processor/lib/api.js on lines 589..595

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status