Sign upLogin

oaeproject/Hilary

View on GitHub
Star
packages/oae-folders/lib/internal/dao.js

Summary

Maintainability
A
35 mins
Test Coverage
A
100%

Function createFolder has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

const createFolder = function (createdBy, displayName, description, visibility, callback) {
Severity: Minor
Found in packages/oae-folders/lib/internal/dao.js - About 35 mins to fix

    Similar blocks of code found in 6 locations. Consider refactoring.
    Invalid

      const { tenantAlias, groupId, createdBy, displayName, description, visibility, created, lastModified, previews } =
    storageHash;
    Severity: Major
    Found in packages/oae-folders/lib/internal/dao.js and 5 other locations - About 55 mins to fix
    packages/oae-jitsi/lib/internal/dao.js on lines 199..200
    packages/oae-jitsi/lib/internal/dao.js on lines 228..228
    packages/oae-jitsi/lib/model.js on lines 21..21
    packages/oae-activity/lib/api.js on lines 45..55
    packages/oae-folders/lib/model.js on lines 41..41

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Invalid

      callbackify(runQuery)(query.query, query.parameters, (error) => {
    if (error) return callback(error);

    return callback(null, _createUpdatedFolderFromStorageHash(folder, storageHash));
  });
    Severity: Major
    Found in packages/oae-folders/lib/internal/dao.js and 4 other locations - About 50 mins to fix
    packages/oae-discussions/lib/internal/dao.js on lines 63..67
    packages/oae-discussions/lib/internal/dao.js on lines 86..90
    packages/oae-jitsi/lib/internal/dao.js on lines 56..60
    packages/oae-jitsi/lib/internal/dao.js on lines 123..127

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Invalid

      return new Folder(tenant, {
    id,
    groupId,
    createdBy,
    displayName,
    Severity: Major
    Found in packages/oae-folders/lib/internal/dao.js and 3 other locations - About 35 mins to fix
    packages/oae-folders/lib/internal/dao.js on lines 362..372
    packages/oae-jitsi/lib/internal/dao.js on lines 43..53
    packages/oae-messagebox/lib/model.js on lines 57..67

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Invalid

    export {
  setPreviews,
  iterateAll,
  getContentItems,
  updateFolder,
    Severity: Minor
    Found in packages/oae-folders/lib/internal/dao.js and 2 other locations - About 35 mins to fix
    packages/oae-messagebox/lib/api.js on lines 1004..1014
    packages/oae-authz/lib/model.js on lines 246..256

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Invalid

      const storageHash = {
    tenantAlias,
    groupId,
    createdBy,
    displayName,
    Severity: Minor
    Found in packages/oae-folders/lib/internal/dao.js and 1 other location - About 35 mins to fix
    packages/oae-authz/lib/permissions.js on lines 72..81

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Invalid

      return new Folder(getTenant(tenantAlias), {
    id,
    groupId,
    createdBy,
    displayName,
    Severity: Major
    Found in packages/oae-folders/lib/internal/dao.js and 3 other locations - About 35 mins to fix
    packages/oae-folders/lib/internal/dao.js on lines 325..335
    packages/oae-jitsi/lib/internal/dao.js on lines 43..53
    packages/oae-messagebox/lib/model.js on lines 57..67

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status