Sign upLogin

oaeproject/Hilary

View on GitHub
Star
packages/oae-search/lib/util.js

Summary

Maintainability
B
6 hrs
Test Coverage
A
97%

Function transformSearchResults has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

const transformSearchResults = function (ctx, transformers, results, callback) {
  const hits = defaultTo({}, path(['body', 'hits', 'hits'], results));
  const resultsTotalCount = path(['body', 'hits', 'total', 'value'], results);

  if (isEmpty(hits)) return callback(null, new SearchModel.SearchResult(resultsTotalCount, []));
Severity: Minor
Found in packages/oae-search/lib/util.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createQueryStringQuery has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

const createQueryStringQuery = function (q, fields, boost) {
  if (isEmpty(keys(fields))) {
    fields = ['displayName^3.0', 'q_high^2.0', 'q_low^0.75'];
  }
Severity: Minor
Found in packages/oae-search/lib/util.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function filterImplicitAccess has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

const filterImplicitAccess = function (ctx) {
  const user = ctx.user();
  if (user && user.isGlobalAdmin()) {
    // If the user is a global admin, they have implicit access to everything
    return null;
Severity: Minor
Found in packages/oae-search/lib/util.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    return callback(
      null,
      filterAnd(filterOr(implicitAccessFilter, explicitAccessFilter), filterTerm('tenantAlias', scope))
    );
Severity: Major
Found in packages/oae-search/lib/util.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

          return callback(null, explicitAccessFilter);
    Severity: Major
    Found in packages/oae-search/lib/util.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return callback(
        null,
        filterOr(
          filterAnd(
            implicitAccessFilter,
      Severity: Major
      Found in packages/oae-search/lib/util.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return callback({
          code: 400,
          msg: 'Anonymous users cannot search for their own resources'
        });
        Severity: Major
        Found in packages/oae-search/lib/util.js - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Invalid

            return {
    q: request.query.q,
    start: request.query.start,
    limit: request.query.limit,
    sort: request.query.sort
          Severity: Minor
          Found in packages/oae-search/lib/util.js and 1 other location - About 55 mins to fix
          packages/oae-principals/lib/rest.group.js on lines 498..503

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status