Sign upLogin

ocadotechnology/rapid-router

View on GitHub
Star
game/static/game/js/blocklyControl.js

Summary

Maintainability
D
2 days
Test Coverage

File blocklyControl.js has 360 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"use strict";

var ocargo = ocargo || {};

ocargo.BlocklyControl = function () {
Severity: Minor
Found in game/static/game/js/blocklyControl.js - About 4 hrs to fix

    Function activeBlocksCount has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

    ocargo.BlocklyControl.prototype.activeBlocksCount = function () {
  var startBlock = this.startBlock();
  var procedureBlocks = this.procedureBlocks();
  var eventBlocks = this.onEventDoBlocks();
  var n = 0;
    Severity: Minor
    Found in game/static/game/js/blocklyControl.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function activeBlocksCount has 74 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    ocargo.BlocklyControl.prototype.activeBlocksCount = function () {
  var startBlock = this.startBlock();
  var procedureBlocks = this.procedureBlocks();
  var eventBlocks = this.onEventDoBlocks();
  var n = 0;
    Severity: Major
    Found in game/static/game/js/blocklyControl.js - About 2 hrs to fix

      Function removeIllegalBlocks has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

      ocargo.BlocklyControl.prototype.removeIllegalBlocks = function () {
  // Buggy blockly doesn't serialise properly on Safari.
  var isSafari =
    navigator.userAgent.indexOf("Safari") !== -1 &&
    navigator.userAgent.indexOf("Chrome") === -1;
      Severity: Minor
      Found in game/static/game/js/blocklyControl.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function count has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function count(block) {
    if (!block) {
      return 0;
    }
      Severity: Major
      Found in game/static/game/js/blocklyControl.js - About 2 hrs to fix

        Consider simplifying this complex logical expression.
        Open

            } else if (
      block.type === "call_proc" ||
      block.type === "move_forwards" ||
      block.type === "turn_left" ||
      block.type === "turn_right" ||
        Severity: Critical
        Found in game/static/game/js/blocklyControl.js - About 1 hr to fix

          Function removeIllegalBlocks has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          ocargo.BlocklyControl.prototype.removeIllegalBlocks = function () {
  // Buggy blockly doesn't serialise properly on Safari.
  var isSafari =
    navigator.userAgent.indexOf("Safari") !== -1 &&
    navigator.userAgent.indexOf("Chrome") === -1;
          Severity: Minor
          Found in game/static/game/js/blocklyControl.js - About 1 hr to fix

            Function setBlockSelected has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

            ocargo.BlocklyControl.prototype.setBlockSelected = function (block, selected) {
  if (!block instanceof Blockly.BlockSvg) {
    return;
  }
            Severity: Minor
            Found in game/static/game/js/blocklyControl.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              function decodeHTML(text) {
    var e = document.createElement("div");
    e.innerHTML = text;
    return e.childNodes.length === 0 ? "" : e.childNodes[0].nodeValue;
  }
            Severity: Major
            Found in game/static/game/js/blocklyControl.js and 1 other location - About 1 hr to fix
            game/static/game/js/pythonControl.js on lines 75..79

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 63.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status