ocadotechnology/rapid-router

View on GitHub
game/static/game/js/foundation/foundation/foundation.dropdown.js

Summary

Maintainability
D
2 days
Test Coverage

File foundation.dropdown.js has 360 lines of code (exceeds 250 allowed). Consider refactoring.
Open

;(function ($, window, document, undefined) {
  'use strict';

  Foundation.libs.dropdown = {
    name : 'dropdown',
Severity: Minor
Found in game/static/game/js/foundation/foundation/foundation.dropdown.js - About 4 hrs to fix

    Function events has 87 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        events : function (scope) {
          var self = this,
              S = self.S;
    
          S(this.scope)
    Severity: Major
    Found in game/static/game/js/foundation/foundation/foundation.dropdown.js - About 3 hrs to fix

      Function _base has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            _base : function (t) {
              var o_p = this.offsetParent(),
                  o = o_p.offset(),
                  p = t.offset();
      
      
      Severity: Minor
      Found in game/static/game/js/foundation/foundation/foundation.dropdown.js - About 1 hr to fix

        Function adjust_pip has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            adjust_pip : function (dropdown, target, settings, position) {
              var sheet = Foundation.stylesheet,
                  pip_offset_base = 8;
        
              if (dropdown.hasClass(settings.mega_class)) {
        Severity: Minor
        Found in game/static/game/js/foundation/foundation/foundation.dropdown.js - About 1 hr to fix

          Function css has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              css : function (dropdown, target) {
                var left_offset = Math.max((target.width() - dropdown.width()) / 2, 8),
                    settings = target.data(this.attr_name(true) + '-init') || this.settings,
                    parentOverflow = dropdown.parent().css('overflow-y') || dropdown.parent().css('overflow');
          
          
          Severity: Minor
          Found in game/static/game/js/foundation/foundation/foundation.dropdown.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (p.missRight == true) {
                      p.left = p.left - this.outerWidth();
                      p.top = p.top + t.outerHeight();
                      this.removeClass('drop-right');
                    } else {
            game/static/game/js/foundation/foundation/foundation.dropdown.js on lines 362..366

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 67.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (p.missLeft == true) {
                      p.left =  p.left + this.outerWidth();
                      p.top = p.top + t.outerHeight();
                      this.removeClass('drop-left');
                    }
            game/static/game/js/foundation/foundation/foundation.dropdown.js on lines 376..382

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 67.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                    if (t.outerWidth() < this.outerWidth() || self.small() || this.hasClass(s.mega_menu)) {
                      self.adjust_pip(this, t, s, p);
                    }
            game/static/game/js/foundation/foundation/foundation.dropdown.js on lines 326..328
            game/static/game/js/foundation/foundation/foundation.dropdown.js on lines 346..348

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 66.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                    if (t.outerWidth() < this.outerWidth() || self.small() || this.hasClass(s.mega_menu)) {
                      self.adjust_pip(this, t, s, p);
                    }
            game/static/game/js/foundation/foundation/foundation.dropdown.js on lines 346..348
            game/static/game/js/foundation/foundation/foundation.dropdown.js on lines 386..388

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 66.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                    if (t.outerWidth() < this.outerWidth() || self.small() || this.hasClass(s.mega_menu)) {
                      self.adjust_pip(this, t, s, p);
                    }
            game/static/game/js/foundation/foundation/foundation.dropdown.js on lines 326..328
            game/static/game/js/foundation/foundation/foundation.dropdown.js on lines 386..388

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 66.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (p.missRight == true) {
                      p.left = p.left - this.outerWidth() + t.outerWidth();
                    }
            game/static/game/js/foundation/foundation/foundation.dropdown.js on lines 342..344

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 52.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (p.missRight == true) {
                      p.left = p.left - this.outerWidth() + t.outerWidth();
                    }
            game/static/game/js/foundation/foundation/foundation.dropdown.js on lines 322..324

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 52.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  S(window)
                    .off('.dropdown')
                    .on('resize.fndtn.dropdown', self.throttle(function () {
                      self.resize.call(self);
                    }, 50));
            game/static/game/js/foundation/foundation/foundation.topbar.js on lines 246..248

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                small : function () {
                  return matchMedia(Foundation.media_queries.small).matches &&
                    !matchMedia(Foundation.media_queries.medium).matches;
                },
            game/static/game/js/foundation/foundation/foundation.joyride.js on lines 405..408
            game/static/game/js/foundation/foundation/foundation.tooltip.js on lines 275..278

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status