Sign upLogin

ocadotechnology/rapid-router

View on GitHub
Star
game/static/game/js/sharing.js

Summary

Maintainability
C
1 day
Test Coverage

Function populateSharingTable has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

ocargo.Sharing.prototype.populateSharingTable = function (recipients) {
  let sharing = this;
  let levelId = this.getLevelId();
  // Remove click listeners to avoid memory leak and remove all rows
  let table = $("#shareLevelTable tbody");
Severity: Major
Found in game/static/game/js/sharing.js - About 2 hrs to fix

    Function populateSharingTable has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    ocargo.Sharing.prototype.populateSharingTable = function (recipients) {
  let sharing = this;
  let levelId = this.getLevelId();
  // Remove click listeners to avoid memory leak and remove all rows
  let table = $("#shareLevelTable tbody");
    Severity: Minor
    Found in game/static/game/js/sharing.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function processSharingInformation has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    ocargo.Sharing.prototype.processSharingInformation = function (
  error,
  validRecipients
) {
  if (error !== null) {
    Severity: Minor
    Found in game/static/game/js/sharing.js - About 1 hr to fix

      Function processSharingInformation has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      ocargo.Sharing.prototype.processSharingInformation = function (
  error,
  validRecipients
) {
  if (error !== null) {
      Severity: Minor
      Found in game/static/game/js/sharing.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          error: function (xhr, errmsg, err) {
      sharing.processSharingInformation(
        xhr.status + ": " + errmsg + " " + err + " " + xhr.responseText
      );
    },
      Severity: Minor
      Found in game/static/game/js/sharing.js and 1 other location - About 50 mins to fix
      game/static/game/js/game.js on lines 276..280

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        if (this.allShared) {
    $("#shareWithAll span").html(gettext("Unshare with all"));
    $("#shareWithAll img").attr(
      "src",
      ocargo.Drawing.imageDir + "icons/quit.svg"
      Severity: Minor
      Found in game/static/game/js/sharing.js and 1 other location - About 45 mins to fix
      game/static/game/js/sharing.js on lines 146..152

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        } else {
    $("#shareWithAll span").html(gettext("Share with all"));
    $("#shareWithAll img").attr(
      "src",
      ocargo.Drawing.imageDir + "icons/share.svg"
      Severity: Minor
      Found in game/static/game/js/sharing.js and 1 other location - About 45 mins to fix
      game/static/game/js/sharing.js on lines 140..146

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status