oceanprotocol/ocean.js

View on GitHub

Showing 61 of 177 total issues

Function createDispenser has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public async createDispenser<G extends boolean = false>(
    dtAddress: string,
    address: string,
    dispenserAddress: string,
    dispenserParams: DispenserParams,
Severity: Minor
Found in src/contracts/Datatoken.ts - About 1 hr to fix

    Function startOrder has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      public async startOrder<G extends boolean = false>(
        dtAddress: string,
        consumer: string,
        serviceIndex: number,
        providerFees: ProviderFees,
    Severity: Minor
    Found in src/contracts/Datatoken.ts - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

        if (feeHistory.maxPriorityFeePerGas) {
          let aggressiveFeePriorityFeePerGas = feeHistory.maxPriorityFeePerGas.toString()
          let aggressiveFeePerGas = feeHistory.maxFeePerGas.toString()
          if (gasFeeMultiplier > 1) {
            aggressiveFeePriorityFeePerGas = Math.round(
      Severity: Major
      Found in src/utils/ContractUtils.ts - About 1 hr to fix

        Function computeStatus has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          public async computeStatus(
            providerUri: string,
            consumerAddress: string,
            jobId?: string,
            did?: string,
        Severity: Minor
        Found in src/services/Provider.ts - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function computeStop has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          public async computeStop(
            did: string,
            consumerAddress: string,
            jobId: string,
            providerUri: string,
        Severity: Minor
        Found in src/services/Provider.ts - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function transfer has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          signer: Signer,
          config: Config,
          tokenAddress: string,
          recipient: string,
          amount: string,
        Severity: Minor
        Found in src/utils/TokenUtils.ts - About 45 mins to fix

          Function sendTx has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            estGas: BigNumber,
            signer: Signer,
            gasFeeMultiplier: number,
            functionToSend: ContractFunction,
            ...args: any[]
          Severity: Minor
          Found in src/utils/ContractUtils.ts - About 35 mins to fix

            Function initialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              public async initialize(
                did: string,
                serviceId: string,
                fileIndex: number,
                consumerAddress: string,
            Severity: Minor
            Found in src/services/Provider.ts - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function computeDelete has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              public async computeDelete(
                did: string,
                consumer: Signer,
                jobId: string,
                providerUri: string,
            Severity: Minor
            Found in src/services/Provider.ts - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function createNFT has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              public async createNFT<G extends boolean = false>(
                nftData: NftCreateData,
                estimateGas?: G
              ): Promise<G extends false ? string : BigNumber> {
                if (!nftData.templateIndex) nftData.templateIndex = 1
            Severity: Minor
            Found in src/contracts/NFTFactory.ts - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getNonce has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              public async getNonce(
                providerUri: string,
                consumerAddress: string,
                signal?: AbortSignal,
                providerEndpoints?: any,
            Severity: Minor
            Found in src/services/Provider.ts - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this function.
            Open

                return false
            Severity: Major
            Found in src/contracts/Dispenser.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return txBuy
              Severity: Major
              Found in src/utils/OrderUtils.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return true
                Severity: Major
                Found in src/contracts/Dispenser.ts - About 30 mins to fix

                  Function getFileInfo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                    public async getFileInfo(
                      file: UrlFile | Arweave | Ipfs | GraphqlQuery | Smartcontract,
                      providerUri: string,
                      withChecksum: boolean = false,
                      signal?: AbortSignal
                  Severity: Minor
                  Found in src/services/Provider.ts - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function computeStart has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                    public async computeStart(
                      providerUri: string,
                      consumer: Signer,
                      computeEnv: string,
                      dataset: ComputeAsset,
                  Severity: Minor
                  Found in src/services/Provider.ts - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function isValidProvider has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                    public async isValidProvider(url: string, signal?: AbortSignal): Promise<boolean> {
                      try {
                        const response = await fetch(url, {
                          method: 'GET',
                          headers: { 'Content-Type': 'application/json' },
                  Severity: Minor
                  Found in src/services/Provider.ts - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function mint has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                    public async mint<G extends boolean = false>(
                      dtAddress: string,
                      address: string,
                      amount: string,
                      toAddress?: string,
                  Severity: Minor
                  Found in src/contracts/Datatoken.ts - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function checkDidFiles has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                    public async checkDidFiles(
                      did: string,
                      serviceId: string,
                      providerUri: string,
                      withChecksum: boolean = false,
                  Severity: Minor
                  Found in src/services/Provider.ts - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getAddressesFromEnv has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                    public getAddressesFromEnv(network: string, customAddresses?: any): Partial<Config> {
                      // use the defaults first
                      let configAddresses: Partial<Config>
                      // load from custom addresses structure
                      if (customAddresses && customAddresses[network]) {
                  Severity: Minor
                  Found in src/config/ConfigHelper.ts - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language