Sign upLogin

oglimmer/citybuilder

View on GitHub
Star
client/game/FieldPane.js

Summary

Maintainability
F
5 days
Test Coverage

Function FieldPane has a Cognitive Complexity of 131 (exceeds 5 allowed). Consider refactoring.
Open

function FieldPane() {

    this.relocateX = 0;  
    this.relocateY = 0;
    this.allElements = [];
Severity: Minor
Found in client/game/FieldPane.js - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function FieldPane has 173 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function FieldPane() {

    this.relocateX = 0;  
    this.relocateY = 0;
    this.allElements = [];
Severity: Major
Found in client/game/FieldPane.js - About 6 hrs to fix

    Function moveover has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        this.moveover = function(x,y) {
        if(!this.selectTargetEnabled) {
            return;
        }
        for(var i = 0 ; i < this.allElements.length ; i++) {
    Severity: Minor
    Found in client/game/FieldPane.js - About 1 hr to fix

      Function calcRanges has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          this.calcRanges = function(type) {    
        for(var i = 0 ; i < this.allElements.length ; i++) {
            var field = this.allElements[i];
            if(field.type == 0 ) {
                field.influenced = 0;
      Severity: Minor
      Found in client/game/FieldPane.js - About 1 hr to fix

        Avoid too many return statements within this function.
        Open

                    return field.type == 0 && field.attachedCard.houseType < this.selectableType.match(/[0-9].*$/);
        Severity: Major
        Found in client/game/FieldPane.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return false;
          Severity: Major
          Found in client/game/FieldPane.js - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                this.forEachField = function(range, field, fields, perField) {
        for(var x = -range ; x <= range ; x++) {
            for(var y = -range ; y <= range ; y++) {
                if(x!=0 || y!=0) {
                    var surroundingElement = fields[(field.x+x)+":"+(field.y+y)];
            Severity: Major
            Found in client/game/FieldPane.js and 1 other location - About 5 hrs to fix
            server/cards/card_basecards.js on lines 46..57

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 135.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if(this.selectableType.match(/ALL_UNOCCUPIED_ABOVE_/) !== null) {
            return field.type == 0 && field.attachedCard.houseType > this.selectableType.match(/[0-9].*$/);
        }
            Severity: Major
            Found in client/game/FieldPane.js and 1 other location - About 1 hr to fix
            client/game/FieldPane.js on lines 39..41

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 62.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if(this.selectableType.match(/ALL_UNOCCUPIED_LOWER_/) !== null) {
            return field.type == 0 && field.attachedCard.houseType < this.selectableType.match(/[0-9].*$/);
        }
            Severity: Major
            Found in client/game/FieldPane.js and 1 other location - About 1 hr to fix
            client/game/FieldPane.js on lines 36..38

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 62.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        for(var j = 0 ; j < this.currentHighlight.length ; j++) {
                this.currentHighlight[j].fillStyleH = null;
                this.currentHighlight[j].draw(G.ctx, this.relocateX, this.relocateY);
            }
            Severity: Major
            Found in client/game/FieldPane.js and 1 other location - About 1 hr to fix
            client/game/FieldPane.js on lines 112..115

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 56.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                            for(var j = 0 ; j < this.currentHighlight.length ; j++) {
                    this.currentHighlight[j].fillStyleH = null;
                    this.currentHighlight[j].draw(G.ctx, this.relocateX, this.relocateY);
                }
            Severity: Major
            Found in client/game/FieldPane.js and 1 other location - About 1 hr to fix
            client/game/FieldPane.js on lines 144..147

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 56.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status