Sign upLogin

oglimmer/citybuilder

View on GitHub
Star

Showing 82 of 157 total issues

Function calcSupplies has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

RentalCard.prototype.calcSupplies = function(field, fields) {    
    Card.forEachField(this.range, field, fields, function(surroundingElement) {
        if(surroundingElement.type == FieldType.HOUSE) {
            if(typeof surroundingElement.attachedCard.supply[RentalCard.getTypeFromField(field)] === 'undefined') {
                surroundingElement.attachedCard.supply[RentalCard.getTypeFromField(field)] = 0;
Severity: Minor
Found in server/cards/card_basecards.js - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createField has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

GameField.prototype.createField = function(x,y,houseType,maxPop,localLevel) {
Severity: Minor
Found in server/rule_gamefield.js - About 35 mins to fix

    Function BuildElectronicCard has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function BuildElectronicCard(id,no,range,profitConfig,localLevelMod) {
    Severity: Minor
    Found in server/cards/card_electroniccards.js - About 35 mins to fix

      Function BuildJeweleryCard has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      function BuildJeweleryCard(id,no,range,profitConfig,localLevelMod) {
      Severity: Minor
      Found in server/cards/card_jewelerycards.js - About 35 mins to fix

        Function Button has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function Button(label,x, y, width, onclick) {
        Severity: Minor
        Found in client/game/Button.js - About 35 mins to fix

          Function BuildClothingCard has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function BuildClothingCard(id,no,range,profitConfig,localLevelMod) {
          Severity: Minor
          Found in server/cards/card_clothingcards.js - About 35 mins to fix

            Function Field has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            function Field(x,y,type,houseCard,localLevel) {
            Severity: Minor
            Found in server/rule_field.js - About 35 mins to fix

              Function add has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              GameField.prototype.add = function(width, height, houseType, maxPop, localLevel) {
              Severity: Minor
              Found in server/rule_gamefield.js - About 35 mins to fix

                Function BuildCriminalCard has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                function BuildCriminalCard(id,no,range,profitConfig,localLevelMod) {
                Severity: Minor
                Found in server/cards/card_criminalcards.js - About 35 mins to fix

                  Function BuildGroceriesCard has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  function BuildGroceriesCard(id,no,range,profitConfig,localLevelMod) {
                  Severity: Minor
                  Found in server/cards/card_groceriescards.js - About 35 mins to fix

                    Function BuildLocalLevelCard has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    function BuildLocalLevelCard(id,no,range,profitConfig,localLevelMod) {
                    Severity: Minor
                    Found in server/cards/card_locallevelcards.js - About 35 mins to fix

                      Function BuildRestaurantCard has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      function BuildRestaurantCard(id,no,range,profitConfig,localLevelMod) {
                      Severity: Minor
                      Found in server/cards/card_restaurantcards.js - About 35 mins to fix

                        Function newPeople has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                        Open

                        NewPeopleCard.newPeople = function(field,changedFields) {
    if(field.type == FieldType.HOUSE) {
        var oldHouseType = field.attachedCard.houseType;        
        var currentHouseTypeName = HouseTypeReverse[oldHouseType];
        var currentLocalLevel = null;
                        Severity: Minor
                        Found in server/cards/card_other.js - About 35 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function onclick has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                        Open

                        CanvasManager.prototype.onclick = function(x, y) {
    if(this.enabled) {
        for(var i = this.elements.length - 1 ; i>= 0 ; i--) {
            var ele = this.elements[i][2];
            if(typeof(ele.onclick) === 'function' && ele.onclick(x,y)) {
                        Severity: Minor
                        Found in client/game/CanvasManager.js - About 35 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function GameField has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                        Open

                        function GameField(game) {
    this.fields = {};
    this.minX = 0;
    this.minY = 0;
    this.maxX = 8;
                        Severity: Minor
                        Found in server/rule_gamefield.js - About 35 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function onclick has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                        Open

                        UIElement.prototype.onclick = function(x, y) {
    if(this.atPos(x,y)) {
        if(G.fieldPane.selectTargetEnabled) {
            // this is a deploy
            if(G.fieldPane.isSelectable(this)) {
                        Severity: Minor
                        Found in client/game/UIElement.js - About 35 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Avoid too many return statements within this function.
                        Open

                                    return field.type == 0 && field.attachedCard.houseType < this.selectableType.match(/[0-9].*$/);
                        Severity: Major
                        Found in client/game/FieldPane.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                              return G.i18n.localLevelTextShort_4;
                          Severity: Major
                          Found in client/game/UIServices.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                return G.i18n.localLevelText_4;
                            Severity: Major
                            Found in client/game/UIServices.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                      return false;
                              Severity: Major
                              Found in client/game/FieldPane.js - About 30 mins to fix
                                Severity
                                Category
                                Status
                                Source
                                Language