Sign upLogin

oglimmer/citybuilder

View on GitHub
Star
server/rule_gamefield.js

Summary

Maintainability
A
3 hrs
Test Coverage

Function add has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

GameField.prototype.add = function(width, height, houseType, maxPop, localLevel) {

    if(this.freeRange.length == 0 ) {
        this.minX -= 3;
        this.minY -= 3;
Severity: Minor
Found in server/rule_gamefield.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createField has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

GameField.prototype.createField = function(x,y,houseType,maxPop,localLevel) {
Severity: Minor
Found in server/rule_gamefield.js - About 35 mins to fix

    Function add has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    GameField.prototype.add = function(width, height, houseType, maxPop, localLevel) {
    Severity: Minor
    Found in server/rule_gamefield.js - About 35 mins to fix

      Function GameField has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      function GameField(game) {
    this.fields = {};
    this.minX = 0;
    this.minY = 0;
    this.maxX = 8;
      Severity: Minor
      Found in server/rule_gamefield.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status