src/redux/actions/links.js
File links.js
has 273 lines of code (exceeds 250 allowed). Consider refactoring. Open
Open
import { actions } from 'react-redux-form';
import { push } from 'react-router-redux';
import assert from 'assert';
import BlueBirdPromise from 'bluebird';
Function updateAfterPersistLink
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
Open
const updateAfterPersistLink = (responseUpdates, linkList, selectedTag, dispatch, successMsg) => {
if (responseUpdates.message) {
dispatch(setErrorMessage(responseUpdates.message));
} else {
const updateLink = (link) => {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function persistLink
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
export function persistLink(linkId, url, tags, rssUrl, pageTitle, notes) {
Function updateLinkPost
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
function updateLinkPost(id, linkUrl, tags, rssUrl, pageTitle, notes) {
Function editLink
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
export function editLink(id, url, tags, rssUrl, pageTitle, notes) {