Sign upLogin

oglimmer/linky

View on GitHub
Star
src/redux/actions/links.js

Summary

Maintainability
C
7 hrs
Test Coverage

File links.js has 273 lines of code (exceeds 250 allowed). Consider refactoring.
Open


import { actions } from 'react-redux-form';
import { push } from 'react-router-redux';
import assert from 'assert';
import BlueBirdPromise from 'bluebird';
Severity: Minor
Found in src/redux/actions/links.js - About 2 hrs to fix

    Function updateAfterPersistLink has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

    const updateAfterPersistLink = (responseUpdates, linkList, selectedTag, dispatch, successMsg) => {
  if (responseUpdates.message) {
    dispatch(setErrorMessage(responseUpdates.message));
  } else {
    const updateLink = (link) => {
    Severity: Minor
    Found in src/redux/actions/links.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function updateLinkPost has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function updateLinkPost(id, linkUrl, tags, rssUrl, pageTitle, notes) {
    Severity: Minor
    Found in src/redux/actions/links.js - About 45 mins to fix

      Function persistLink has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      export function persistLink(linkId, url, tags, rssUrl, pageTitle, notes) {
      Severity: Minor
      Found in src/redux/actions/links.js - About 45 mins to fix

        Function editLink has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        export function editLink(id, url, tags, rssUrl, pageTitle, notes) {
        Severity: Minor
        Found in src/redux/actions/links.js - About 45 mins to fix

          There are no issues that match your filters.

          Category
          Status