oleksiyk/kafka

View on GitHub
lib/group_consumer.js

Summary

Maintainability
C
1 day
Test Coverage

File group_consumer.js has 260 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

var Promise      = require('./bluebird-configured');
var _            = require('lodash');
var BaseConsumer = require('./base_consumer');
Severity: Minor
Found in lib/group_consumer.js - About 2 hrs to fix

    Function _syncGroup has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    GroupConsumer.prototype._syncGroup = function () {
        var self = this;
    
        return Promise.try(function () {
            if (self.memberId === self.leaderId) { // leader should generate group assignments
    Severity: Minor
    Found in lib/group_consumer.js - About 1 hr to fix

      Function init has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      GroupConsumer.prototype.init = function (strategies) {
          var self = this;
      
          return BaseConsumer.prototype.init.call(self).then(function () {
              if (_.isEmpty(strategies)) {
      Severity: Minor
      Found in lib/group_consumer.js - About 1 hr to fix

        Function _updateSubscriptions has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        GroupConsumer.prototype._updateSubscriptions = function (partitionAssignment) {
            var self = this, offsetRequests = [],
                handler = self.strategies[self.strategyName].handler;
        
            self.subscriptions = {};
        Severity: Minor
        Found in lib/group_consumer.js - About 1 hr to fix

          Function _joinGroup has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          GroupConsumer.prototype._joinGroup = function () {
              var self = this;
          
              return (function _tryJoinGroup(attempt) {
                  attempt = attempt || 0;
          Severity: Minor
          Found in lib/group_consumer.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    return self.client.joinConsumerGroupRequest(self.options.groupId, self.memberId, self.options.sessionTimeout, _.values(self.strategies))
                    .catch({ code: 'GroupCoordinatorNotAvailable' }, function () {
                        return Promise.delay(1000).then(function () {
                            return _tryJoinGroup(++attempt);
                        });
            Severity: Minor
            Found in lib/group_consumer.js and 1 other location - About 35 mins to fix
            lib/group_consumer.js on lines 179..186

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    return self._joinGroup().then(function () {
                        return self._syncGroup();
                    })
                    .catch({ code: 'RebalanceInProgress' }, function () {
                        return Promise.delay(1000).then(function () {
            Severity: Minor
            Found in lib/group_consumer.js and 1 other location - About 35 mins to fix
            lib/group_consumer.js on lines 94..99

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status